Skip to content

Commit

Permalink
Fix native module lookup followup from D28630805
Browse files Browse the repository at this point in the history
Summary:
In D28630805 (f78526c) ([github link](#31457)) I added a setter to workaround a bug I perceived with `moduleRegistry`. Turns out - the proper fix was to remove the `synthesize` line. See conversation on linked diff for more context.

Changelog: [Internal]

Reviewed By: RSNara

Differential Revision: D29144717

fbshipit-source-id: aa95b670b540b9007eed76769c9babc10ea399ce
  • Loading branch information
Peter Argany authored and facebook-github-bot committed Jun 16, 2021
1 parent e91fb05 commit c3dffe0
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions Libraries/Network/RCTNetworking.mm
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,6 @@ @implementation RCTNetworking
}

@synthesize methodQueue = _methodQueue;
@synthesize moduleRegistry = _moduleRegistry;

RCT_EXPORT_MODULE()

Expand Down Expand Up @@ -190,14 +189,6 @@ - (void)invalidate
_responseHandlers = nil;
}

// TODO (T93136931) - Investigate why this is needed. This setter shouldn't be
// necessary, since moduleRegistry is a property on RCTEventEmitter (which this
// class inherits from).
- (void)setModuleRegistry:(RCTModuleRegistry *)moduleRegistry
{
_moduleRegistry = moduleRegistry;
}

- (NSArray<NSString *> *)supportedEvents
{
return @[@"didCompleteNetworkResponse",
Expand Down

0 comments on commit c3dffe0

Please sign in to comment.