Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ModalHostView's child view can not fill screen (#18615)
Summary: Signed-off-by: yukai <[email protected]> In some Android device such as Samsung S8, the ModalHostView's child view can't fill the screen. before: ![before](https://user-images.githubusercontent.com/1514899/38024961-3e756f8e-32b9-11e8-9555-50a7cf778288.jpeg) The JS ModalHostView can't fill the bottom, the area is device's navigation bar. In class ModalHostShadowNode, follow code calculate is error: `Point modalSize = ModalHostHelper.getModalHostSize(getThemedContext());` This way not care the device's navigation bar, so the height is smaller than real. For Samsung S8, real height is 2220 and modalSize.y is 2076. Pull Request resolved: #18615 Differential Revision: D14206830 Pulled By: cpojer fbshipit-source-id: abe35ce1ab253aa1472d2c798543b515218be445
- Loading branch information