Skip to content

Commit

Permalink
Fail Xcode build if Build JS Bundle script phase fails (#39113)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #39113

This diff makes Xcode build fail if `Build JS Bundle` script phase fails. Before that the script phase could fail silently resulting in subltle breakages. E.g. we could get seemingly working app that doesn't have proper jsbundle or source maps.
Changelog: [IOS][Fixed] - Fail Xcode build if Build JS Bundle script phase fails.

Reviewed By: motiz88

Differential Revision: D48562229

fbshipit-source-id: 247e271b1ce28061418bb7a8277dcabf3dcf99aa
  • Loading branch information
dmytrorykun authored and facebook-github-bot committed Aug 29, 2023
1 parent 46d6200 commit a56e5da
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/react-native/scripts/react-native-xcode.sh
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
# and relies on environment variables (including PWD) set by Xcode

# Print commands before executing them (useful for troubleshooting)
set -x
set -x -e
DEST=$CONFIGURATION_BUILD_DIR/$UNLOCALIZED_RESOURCES_FOLDER_PATH

# Enables iOS devices to get the IP address of the machine running Metro
Expand Down

0 comments on commit a56e5da

Please sign in to comment.