Refactor NativeModule API

Summary:
EZ refactor NativeModule API:
- Reorder methods
- Add default implementation for deprecated methods

changelog: [internal] internal

Reviewed By: philIip

Differential Revision: D50610164

fbshipit-source-id: dd9dbf57be2b38c1c247858b6144f7fc6ef0fd31

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/NativeModule.java

@@ -33,23 +33,25 @@ public interface NativeModule {
   /** This method is called after {@link ReactApplicationContext} has been created. */
   void initialize();
 
+  /** Allow NativeModule to clean up. Called before React Native instance is destroyed. */
+  void invalidate();
+
   /**
    * Return true if you intend to override some other native module that was registered e.g. as part
    * of a different package (such as the core one). Trying to override without returning true from
    * this method is considered an error and will throw an exception during initialization. By
    * default all modules return false.
    */
   @DeprecatedInNewArchitecture()
-  boolean canOverrideExistingModule();
+  default boolean canOverrideExistingModule() {
+    return false;
+  }
 
   /**
    * Allow NativeModule to clean up. Called before {CatalystInstance#onHostDestroy}
    *
    * @deprecated use {@link #invalidate()} instead.
    */
   @Deprecated(since = "Use invalidate method instead", forRemoval = true)
-  void onCatalystInstanceDestroy();
-
-  /** Allow NativeModule to clean up. Called before React Native instance is destroyed. */
-  void invalidate();
+  default void onCatalystInstanceDestroy() {}
 }