Skip to content

Commit

Permalink
RCTTouchHandler doesn't delay any touches anymore
Browse files Browse the repository at this point in the history
Reviewed By: mmmulani

Differential Revision: D4418211

fbshipit-source-id: 07fdd81d975c6b65477e599e2dcb604b64556e9e
  • Loading branch information
shergin authored and facebook-github-bot committed Jan 14, 2017
1 parent 8045a70 commit 930010e
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion React/Base/RCTTouchHandler.m
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,12 @@ - (instancetype)initWithBridge:(RCTBridge *)bridge
_reactTouches = [NSMutableArray new];
_touchViews = [NSMutableArray new];

// `cancelsTouchesInView` is needed in order to be used as a top level
// `cancelsTouchesInView` and `delaysTouches*` are needed in order to be used as a top level
// event delegated recognizer. Otherwise, lower-level components not built
// using RCT, will fail to recognize gestures.
self.cancelsTouchesInView = NO;
self.delaysTouchesBegan = NO; // This is default value.
self.delaysTouchesEnded = NO;

self.delegate = self;
}
Expand Down

2 comments on commit 930010e

@brentvatne
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any context around this?

@shergin
Copy link
Contributor Author

@shergin shergin commented on 930010e Feb 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brentvatne After landing epic c68a708 we found that <NavigatorIOS> stoped working because of delaying "ends" of touches. So, we turn if off because we have no idea why we should delay it.

Do you have any concerns?

Please sign in to comment.