Skip to content

Commit

Permalink
Restore installing DevSupport to all the config
Browse files Browse the repository at this point in the history
Summary:
CircleCI was broken because we changed how the `React-Core/DevSupport` pod is installed.

## Changelog:
[Internal] - Restore the installation of React-Core/DevSupport

Reviewed By: cortinico

Differential Revision: D46734714

fbshipit-source-id: 9b8c28837f0485ed0df2f94e417f89b5f0077c7d
  • Loading branch information
cipolleschi authored and facebook-github-bot committed Jun 14, 2023
1 parent 202b965 commit 875f6a7
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@ def test_installFlipperDependencies_installDependencies

# Assert
assert_equal($podInvocationCount, 1)
assert_equal($podInvocation['React-Core/DevSupport'][:path], "../../" )
assert_equal($podInvocation['React-Core/DevSupport'][:configurations], ["Debug"] )
assert_equal($podInvocation['React-Core/DevSupport'][:path], "../../")
end

# ======================= #
Expand Down
4 changes: 2 additions & 2 deletions packages/react-native/scripts/cocoapods/flipper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@
# when the dependencies are installed for a non production app.
#
# @parameter pathToReactNative: the path to the React Native installation
def install_flipper_dependencies(pathToReactNative, configurations: ["Debug"])
pod 'React-Core/DevSupport', :path => "#{pathToReactNative}/", :configurations => configurations
def install_flipper_dependencies(pathToReactNative)
pod 'React-Core/DevSupport', :path => "#{pathToReactNative}/"
end


Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/scripts/react_native_pods.rb
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ def use_react_native! (

# Flipper now build in Release mode but it is not linked to the Release binary (as specified by the Configuration option)
if flipper_configuration.flipper_enabled
install_flipper_dependencies(prefix, :configurations => flipper_configuration.configurations)
install_flipper_dependencies(prefix)
use_flipper_pods(flipper_configuration.versions, :configurations => flipper_configuration.configurations)
end

Expand Down

0 comments on commit 875f6a7

Please sign in to comment.