Android

facebook · Jul 28, 2019 · 7d0964c · 7d0964c
1 parent 7dd6dee
commit 7d0964c
Show file tree

Hide file tree

Showing 4 changed files with 33 additions and 4 deletions.
diff --git a/ReactAndroid/src/main/java/com/facebook/react/CoreModulesPackage.java b/ReactAndroid/src/main/java/com/facebook/react/CoreModulesPackage.java
@@ -139,7 +139,7 @@ public NativeModule getModule(String name, ReactApplicationContext reactContext)
       case DeviceEventManagerModule.NAME:
         return new DeviceEventManagerModule(reactContext, mHardwareBackBtnHandler);
       case DevSettingsModule.NAME:
-        return new DevSettingsModule(mReactInstanceManager.getDevSupportManager());
+        return new DevSettingsModule(reactContext, mReactInstanceManager.getDevSupportManager());
       case ExceptionsManagerModule.NAME:
         return new ExceptionsManagerModule(mReactInstanceManager.getDevSupportManager());
       case HeadlessJsTaskSupportModule.NAME:

diff --git a/ReactAndroid/src/main/java/com/facebook/react/devsupport/DevInternalSettings.java b/ReactAndroid/src/main/java/com/facebook/react/devsupport/DevInternalSettings.java
@@ -166,6 +166,11 @@ public void setRemoteJSDebugEnabled(boolean remoteJSDebugEnabled) {
     mPreferences.edit().putBoolean(PREFS_REMOTE_JS_DEBUG_KEY, remoteJSDebugEnabled).apply();
   }
 
+  @Override
+  public void addMenuItem(String title) {
+    // Not supported.
+  }
+
   public interface Listener {
     void onInternalSettingsChanged();
   }

diff --git a/ReactAndroid/src/main/java/com/facebook/react/modules/debug/DevSettingsModule.java b/ReactAndroid/src/main/java/com/facebook/react/modules/debug/DevSettingsModule.java
@@ -6,23 +6,30 @@
  */
 package com.facebook.react.modules.debug;
 
-import com.facebook.react.bridge.BaseJavaModule;
+import com.facebook.react.bridge.Arguments;
+import com.facebook.react.bridge.ReactApplicationContext;
+import com.facebook.react.bridge.ReactContextBaseJavaModule;
 import com.facebook.react.bridge.ReactMethod;
 import com.facebook.react.bridge.UiThreadUtil;
+import com.facebook.react.bridge.WritableMap;
 import com.facebook.react.devsupport.interfaces.DevSupportManager;
+import com.facebook.react.devsupport.interfaces.DevOptionHandler;
 import com.facebook.react.module.annotations.ReactModule;
+import com.facebook.react.modules.core.DeviceEventManagerModule.RCTDeviceEventEmitter;
 
 /**
  * Module that exposes the URL to the source code map (used for exception stack trace parsing) to JS
  */
 @ReactModule(name = DevSettingsModule.NAME)
-public class DevSettingsModule extends BaseJavaModule {
+public class DevSettingsModule extends ReactContextBaseJavaModule {
 
   public static final String NAME = "DevSettings";
 
   private final DevSupportManager mDevSupportManager;
 
-  public DevSettingsModule(DevSupportManager devSupportManager) {
+  public DevSettingsModule(ReactApplicationContext reactContext, DevSupportManager devSupportManager) {
+    super(reactContext);
+
     mDevSupportManager = devSupportManager;
   }
 
@@ -68,4 +75,18 @@ public void setProfilingEnabled(boolean isProfilingEnabled) {
   public void toggleElementInspector() {
     mDevSupportManager.toggleElementInspector();
   }
+
+  @ReactMethod
+  public void addMenuItem(String title) {
+    mDevSupportManager.addCustomDevOption(title, new DevOptionHandler() {
+      @Override
+      public void onOptionSelected() {
+        WritableMap data = Arguments.createMap();
+        data.putString("title", title);
+        getReactApplicationContext()
+          .getJSModule(RCTDeviceEventEmitter.class)
+          .emit("didPressMenuItem", data);
+      }
+    });
+  }
 }
diff --git a/...tAndroid/src/main/java/com/facebook/react/modules/debug/interfaces/DeveloperSettings.java b/...tAndroid/src/main/java/com/facebook/react/modules/debug/interfaces/DeveloperSettings.java
@@ -32,4 +32,7 @@ public interface DeveloperSettings {
 
   /** Enable/Disable remote JS debugging. */
   void setRemoteJSDebugEnabled(boolean remoteJSDebugEnabled);
+
+  /** Add an item to the dev menu. */
+  void addMenuItem(String title);
 }