Skip to content

Commit

Permalink
Downgrade TurboModule crash to warning
Browse files Browse the repository at this point in the history
Summary:
This is to address a UBN blocking FBiOSv300 rollout. A TM is attempting to invoke a promise more than once and crashing. We can't find the TM, so downgrading this to a warning to unblock the release.

Plan going forward:
- Replace this with some better logging to try and identify the culprit module.

Changelog: [Internal]

Reviewed By: RSNara

Differential Revision: D25539676

fbshipit-source-id: 5b75b71110eaa393378049de6e0d9a77e6328831
  • Loading branch information
Peter Argany authored and facebook-github-bot committed Dec 14, 2020
1 parent 18149e4 commit 687ddf0
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,8 @@ static int32_t getUniqueId()
}

if (resolveWasCalled) {
throw std::runtime_error("Tried to resolve a promise more than once.");
RCTLogWarn(@"Tried to resolve a promise more than once.");
return;
}

auto strongResolveWrapper = weakResolveWrapper.lock();
Expand Down

0 comments on commit 687ddf0

Please sign in to comment.