Skip to content

Commit

Permalink
Add Android Helloworld test on PR (#45019)
Browse files Browse the repository at this point in the history
Summary:
Use GHA on PRs:
1. run test_android_helloworld when users create a PR, to provide coverage while we figure out what's going on with our CircleCI tests / deprecate them.

2. fixes uploading the `.apks` that are generated.

Changelog: [Internal]

Pull Request resolved: #45019

Test Plan: Does GHA run for this PR?

Reviewed By: cipolleschi

Differential Revision: D58728019

Pulled By: blakef

fbshipit-source-id: c6db41d60225702d50343384f103585d83e3528c
  • Loading branch information
blakef authored and facebook-github-bot committed Jun 18, 2024
1 parent 01f7ab8 commit 64d5de7
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .github/workflows/test-all.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ name: Test All

on:
workflow_dispatch:
pull_request:
push:
branches:
- main
Expand Down Expand Up @@ -875,7 +876,7 @@ jobs:
uses: actions/[email protected]
with:
name: template-apk-${{ matrix.flavor }}-${{ matrix.architecture }}-${{ matrix.jsengine }}
path: ./app/build/outputs/apk/
path: packages/helloworld/app/build/outputs/apk/
compression-level: 0

test_ios_helloworld_with_ruby_3_2_0:
Expand Down

0 comments on commit 64d5de7

Please sign in to comment.