-
Notifications
You must be signed in to change notification settings - Fork 24.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Summary: For navigation actions at high level, reducers from NavigationReducers does not know anything about the app-specific state thus people won't use these reducers. Instead, people should build their own reducers. There are a lot of good libraries available that help people to reducing things if that's what they really need. At the low level, for navigation state changes that don't involve app-specific state, `NavigationStateUtils` should server that kind of need. `NavigationReducers` serves little benefit cause it does not know the app state, it does not know how to traverse the navigation states which can be a tree, a list or a map. That said, we hold no interest in owning in the core navigation library. Reviewed By: ericvicenti Differential Revision: D3372910 fbshipit-source-id: 797382b46e7d64b7ad578b51dd37e2b941faa83d
- Loading branch information
Hedger Wang
authored and
Facebook Github Bot 4
committed
Jun 8, 2016
1 parent
bb9ed2d
commit 3a8b50a
Showing
10 changed files
with
52 additions
and
538 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 changes: 0 additions & 41 deletions
41
Libraries/NavigationExperimental/Reducer/NavigationFindReducer.js
This file was deleted.
Oops, something went wrong.
24 changes: 0 additions & 24 deletions
24
Libraries/NavigationExperimental/Reducer/NavigationReducer.js
This file was deleted.
Oops, something went wrong.
102 changes: 0 additions & 102 deletions
102
Libraries/NavigationExperimental/Reducer/NavigationStackReducer.js
This file was deleted.
Oops, something went wrong.
103 changes: 0 additions & 103 deletions
103
Libraries/NavigationExperimental/Reducer/NavigationTabsReducer.js
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
3a8b50a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
3a8b50a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @hedgerwang , I appreciate the NavigationExperimental component very much, Could you tell me we where can I found the latest document about this component, I found the navigation-rfc project is not maintained.
3a8b50a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xing-zheng : we're working on the documentation and they should be ready in few weeks.