Skip to content

Commit

Permalink
zIndex prop was removed from RCTShadowView
Browse files Browse the repository at this point in the history
Summary:
This was leftovers from old implementation of zIndex feature.
Janic janicduplessis refactored this and moved all logic to UIView layer, so we don't need this prop anymore in shadow realm.
More info: #14011

Reviewed By: mmmulani

Differential Revision: D6574414

fbshipit-source-id: 2cae19350765689784d7884ed875878d39b4e3f1
  • Loading branch information
shergin authored and facebook-github-bot committed Dec 18, 2017
1 parent 4803419 commit 2789ba0
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 16 deletions.
5 changes: 0 additions & 5 deletions React/Views/RCTShadowView.h
Original file line number Diff line number Diff line change
Expand Up @@ -170,11 +170,6 @@ typedef void (^RCTApplierBlock)(NSDictionary<NSNumber *, UIView *> *viewRegistry

@property (nonatomic, assign) float aspectRatio;

/**
* z-index, used to override sibling order in the view
*/
@property (nonatomic, assign) NSInteger zIndex;

/**
* Interface direction (LTR or RTL)
*/
Expand Down
10 changes: 0 additions & 10 deletions React/Views/RCTShadowView.m
Original file line number Diff line number Diff line change
Expand Up @@ -792,16 +792,6 @@ - (void)setBackgroundColor:(UIColor *)color
[self dirtyPropagation];
}

- (void)setZIndex:(NSInteger)zIndex
{
_zIndex = zIndex;
if (_superview) {
// Changing zIndex means the subview order of the parent needs updating
_superview->_didUpdateSubviews = YES;
[_superview dirtyPropagation];
}
}

- (void)didUpdateReactSubviews
{
// Does nothing by default
Expand Down
1 change: 0 additions & 1 deletion React/Views/RCTViewManager.m
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,6 @@ - (RCTViewManagerUIBlock)uiBlockToAmendWithShadowViewRegistry:(__unused NSDictio

RCT_EXPORT_SHADOW_PROPERTY(onLayout, RCTDirectEventBlock)

RCT_EXPORT_SHADOW_PROPERTY(zIndex, NSInteger)
RCT_EXPORT_SHADOW_PROPERTY(direction, YGDirection)

@end

0 comments on commit 2789ba0

Please sign in to comment.