Skip to content

Commit

Permalink
Back out "RN: Enable useInsertionEffectsForAnimations" (#48669)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #48669

Original commit changeset: d09b2f1b7607

Original Phabricator Diff: D65906157

[General] [Fixed] - Disable useInsertionEffectsForAnimations, Fix buttons becoming unresponsive when transform is animated

Reviewed By: yungsters

Differential Revision: D68152746

fbshipit-source-id: aa0c0aa3243c67c95128a75b40dd6aa1251abbca
  • Loading branch information
sammy-SC authored and robhogan committed Jan 15, 2025
1 parent 36a0cad commit 2013bad
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -546,11 +546,13 @@ const definitions: FeatureFlagDefinitions = {
},
},
useInsertionEffectsForAnimations: {
defaultValue: true,
defaultValue: false,
metadata: {
dateAdded: '2024-09-12',
description:
'Changes construction of the animation graph to `useInsertionEffect` instead of `useLayoutEffect`.',
purpose: 'release',
expectedReleaseValue: true,
purpose: 'experimentation',
},
},
useRefsForTextInputState: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,11 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
<<<<<<< HEAD
* @generated SignedSource<<83b5798ee1c7a28fffbf110e19641d69>>
=======
* @generated SignedSource<<3bdec862f75745ce81e9cf23fef82468>>
>>>>>>> c799aa07e21 (Back out "RN: Enable `useInsertionEffectsForAnimations`" (#48669))
* @flow strict
*/

Expand Down Expand Up @@ -170,7 +174,7 @@ export const shouldUseSetNativePropsInFabric: Getter<boolean> = createJavaScript
/**
* Changes construction of the animation graph to `useInsertionEffect` instead of `useLayoutEffect`.
*/
export const useInsertionEffectsForAnimations: Getter<boolean> = createJavaScriptFlagGetter('useInsertionEffectsForAnimations', true);
export const useInsertionEffectsForAnimations: Getter<boolean> = createJavaScriptFlagGetter('useInsertionEffectsForAnimations', false);

/**
* Enable a variant of TextInput that moves some state to refs to avoid unnecessary re-renders
Expand Down

0 comments on commit 2013bad

Please sign in to comment.