Skip to content

Commit

Permalink
fix direction of VerticalSwipeJump gestures
Browse files Browse the repository at this point in the history
Summary:
When something comes in from the right, we swipe from left to
right to move back. That means, when something comes in from the bottom,
we should swipe from top to bottom to get rid of it. This diff makes that
behavior occur - right now it's somewhat nonsensical as both jumpBack
and jumpForward are mapped to the same gesture.

thanks to #11192 for making gestures work on VerticalUpSwipeJumps

Reviewed By: ericvicenti, shergin

Differential Revision: D4412129

fbshipit-source-id: 6a3b202b0a90ca459b4ef106ba5bf48d0b1aec9e
  • Loading branch information
mngyuan authored and facebook-github-bot committed Jan 13, 2017
1 parent 154e183 commit 09801aa
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions Libraries/CustomComponents/Navigator/NavigatorSceneConfigs.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@
'use strict';

var Dimensions = require('Dimensions');
var PixelRatio = require('PixelRatio');
var I18nManager = require('I18nManager');
var PixelRatio = require('PixelRatio');

var buildStyleInterpolator = require('buildStyleInterpolator');

Expand Down Expand Up @@ -745,7 +745,7 @@ var NavigatorSceneConfigs = {
...BaseConfig,
gestures: {
jumpBack: {
...BaseDownUpGesture,
...BaseUpDownGesture,
overswipe: BaseOverswipeConfig,
edgeHitWidth: null,
isDetachable: true,
Expand All @@ -766,7 +766,7 @@ var NavigatorSceneConfigs = {
...BaseConfig,
gestures: {
jumpBack: {
...BaseUpDownGesture,
...BaseDownUpGesture,
overswipe: BaseOverswipeConfig,
edgeHitWidth: null,
isDetachable: true,
Expand Down

0 comments on commit 09801aa

Please sign in to comment.