-
Notifications
You must be signed in to change notification settings - Fork 24.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Bump compileSdkVersion to 27 and buildToolsVersion to 27.0.3 (#20777)
Summary: I found that android support library 27.x (874cca1) requires compileSdkVersion to be 27. Also found that many FB projects use SDK 27. Pull Request resolved: #20777 Differential Revision: D9478431 Pulled By: hramos fbshipit-source-id: ca100f6b5b39e7d112926124423f9510a0efc291
- Loading branch information
1 parent
e3165c6
commit 044b399
Showing
8 changed files
with
16 additions
and
16 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
|
||
[android] | ||
target = android-26 | ||
target = android-27 | ||
|
||
[download] | ||
max_number_of_retries = 3 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,8 +18,8 @@ LABEL maintainer="Héctor Ramos <[email protected]>" | |
|
||
# set default build arguments | ||
ARG SDK_VERSION=sdk-tools-linux-3859397.zip | ||
ARG ANDROID_BUILD_VERSION=26 | ||
ARG ANDROID_TOOLS_VERSION=26.0.3 | ||
ARG ANDROID_BUILD_VERSION=27 | ||
ARG ANDROID_TOOLS_VERSION=27.0.3 | ||
ARG BUCK_VERSION=v2018.07.23.01 | ||
ARG NDK_VERSION=17b | ||
ARG NODE_VERSION=8.10.0 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
044b399
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll need to partially back out this commit. We do not yet have Android SDK 27 available internally, which is preventing our Gradle tests from running successfully.