Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs about debugging native code #3614

Merged
merged 8 commits into from
Mar 7, 2023
Merged

Update docs about debugging native code #3614

merged 8 commits into from
Mar 7, 2023

Conversation

tuliocll
Copy link
Contributor

@tuliocll tuliocll commented Mar 7, 2023

Hi guys, I just update the docs adding info about debugging native code with a way to use the IDE debuggers on running RN applications.
Inglish is not my native language, so if there is something wrong appoint me 😅

@facebook-github-bot
Copy link

Hi @tuliocll!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@netlify
Copy link

netlify bot commented Mar 7, 2023

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit 8b583bd
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/64077fc5bff70e0007f7116e
😎 Deploy Preview https://deploy-preview-3614--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@iammstarkdev
Copy link

Thanks @tuliocll, this solved my problem!!! <3

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Copy link
Collaborator

@Simek Simek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @tuliocll, thank you for providing an additional information! 🙏

Left a few minor suggestion related to the formatting, but overall this looks good.

Can you also update at least the latest stable release versioned doc?

docs/debugging.md Outdated Show resolved Hide resolved
docs/debugging.md Outdated Show resolved Hide resolved
docs/debugging.md Outdated Show resolved Hide resolved
@tuliocll
Copy link
Contributor Author

tuliocll commented Mar 7, 2023

Hello @tuliocll, thank you for providing an additional information! 🙏

Left a few minor suggestion related to the formatting, but overall this looks good.

Can you also update at least the latest stable release versioned doc?

Done!

Copy link
Collaborator

@Simek Simek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the backport! 🚀

docs/debugging.md Outdated Show resolved Hide resolved
@Simek Simek merged commit 4d94594 into facebook:main Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants