-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix Prism CodeBlock appearance after the update #3143
Conversation
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
I think the problem is in the custom prism theme plain: {
color: '#FFFFFF',
+ backgroundColor: '#282C34',
- background: '#282C34',
}, Afaik all existing prism themes use Where is "background" coming from? Typo, or should we support/fallback to it? |
We were using this custom theme for a few years, and every Docusaurus release until latest update was working fine with the Refs: facebook/docusaurus#7172 |
Not sure why it worked before, but using the correct prism theme key definitively works better now :D |
@Simek this file seems related to VS Code tooling Also this theme has a I'd rather ask the maintainer: @jpdriver should we support in Docusaurus a fallback so that a Prism theme with To me it looks like a theme mistake and users should just use |
@slorber unfortunately i'd say yes -- go with implementing a fallback for now. we're hoping to overhaul styling for |
Why
After the latest Docusuaurs update it look like the theme variable overwrites the background color set in the custom Prism theme:
This results in display issues, especially in light mode:
How
Overwrite the CodeBlock container background color, loose the class name selectors, remove the not working dark mode style.
I have re-enabled the
--deepdark
tweak, but it leads to the situation where Header and CodeBlocks have the same background color, so let's avoid that.Preview