Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix website GA config #3057

Merged
merged 1 commit into from
Apr 6, 2022
Merged

fix website GA config #3057

merged 1 commit into from
Apr 6, 2022

Conversation

Simek
Copy link
Collaborator

@Simek Simek commented Apr 6, 2022

Refs:

This PR moves the GA config to the preset to fix the degraded data issue.

CC @slorber

@netlify
Copy link

netlify bot commented Apr 6, 2022

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit 990f87a
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/624d6b8d36d9880009e02868
😎 Deploy Preview https://deploy-preview-3057--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kelset kelset mentioned this pull request Apr 6, 2022
@lunaleaps
Copy link
Contributor

Whoa thank you @kelset and @Simek for tracking this down and fixing! Will monitor if this fixes, thank you guys again!

@lunaleaps lunaleaps merged commit 22ddb38 into facebook:main Apr 6, 2022
@Simek Simek deleted the fix-ga-config branch April 6, 2022 20:52
@slorber
Copy link
Contributor

slorber commented Apr 29, 2022

Note: we'll soon have to migrate all sites to Google Analytics 4, as former analytics are being shut down by Google in 2023

facebook/docusaurus#7221

As the data can't be migrated from old to new analytics, it may be better to run old/new analytics together for this year, otherwise the transition will more brutal if you rely on analytics

I have no idea who manages the analytics accounts at Meta and how it's used 🤪 just wanted you to be aware of this @Simek @lunaleaps

@lunaleaps
Copy link
Contributor

lunaleaps commented May 23, 2022

Thanks for the heads up! I'll make an issue for this

Edit: Made this issue: #3142

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants