-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update announceForAccessibility with queue #2862
docs: update announceForAccessibility with queue #2862
Conversation
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@Simek — Logistical question… when facebook/react-native#32637 is merged, do I need to wait before merging this? |
@yungsters Depends on the timeframe, every case need an individual approach. Sometimes you need to wait even for the publish of next release, if upcoming version branch has been already cut, and PR has been merged only on This is because |
So the PR has been merged to main, but 0.67 has already been cut. That means I have to wait until 0.67 is released before I can merge this, right? cc @lunaleaps, @rachelnabors - This is an interesting point of coordination friction that can also lead to outdated docs, relevant to our discussion about keeping reference docs more up-to-date. |
I've updated this to reflect the changes made when facebook/react-native#32637 was merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, it looks like this PR, slip through and was not merged after 0.67
release, sorry about that!
@peterc1731 Can you backport the change also to the 0.68
docs file?
… into feat/queue-a11y-announcements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated the docs for 0.68
, so this should b ready to ship.
Thank you @peterc1731, for the update in the first place! 👍
This PR adds documentation for
announceForAccessibilityWithOptions
, added in facebook/react-native#32637