Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update announceForAccessibility with queue #2862

Merged
merged 4 commits into from
Mar 31, 2022

Conversation

peterc1731
Copy link
Contributor

@peterc1731 peterc1731 commented Nov 25, 2021

This PR adds documentation for announceForAccessibilityWithOptions, added in facebook/react-native#32637

@peterc1731 peterc1731 changed the title feat: update announceForAccessibility with queue docs: update announceForAccessibility with queue Nov 25, 2021
@netlify
Copy link

netlify bot commented Nov 25, 2021

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit f58d26d
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/62457de8c543a600087097a3
😎 Deploy Preview https://deploy-preview-2862--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Simek Simek added 🕐 Waiting on PR These may be waiting for a PR to the facebook/react-native to be merged Wait on future Release This indicates a PR that updates the doc to match a future release. labels Nov 25, 2021
@yungsters
Copy link
Contributor

@Simek — Logistical question… when facebook/react-native#32637 is merged, do I need to wait before merging this?

@Simek
Copy link
Collaborator

Simek commented Nov 30, 2021

@yungsters Depends on the timeframe, every case need an individual approach. Sometimes you need to wait even for the publish of next release, if upcoming version branch has been already cut, and PR has been merged only on main.

This is because next doc should always reflect the state of next release (0.67 ATM), so additional or future changes need to wait until next will become the docs for their target release.

@yungsters
Copy link
Contributor

So the PR has been merged to main, but 0.67 has already been cut. That means I have to wait until 0.67 is released before I can merge this, right?

cc @lunaleaps, @rachelnabors - This is an interesting point of coordination friction that can also lead to outdated docs, relevant to our discussion about keeping reference docs more up-to-date.

@peterc1731
Copy link
Contributor Author

I've updated this to reflect the changes made when facebook/react-native#32637 was merged

Copy link
Collaborator

@Simek Simek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, it looks like this PR, slip through and was not merged after 0.67 release, sorry about that!

@peterc1731 Can you backport the change also to the 0.68 docs file?

Copy link
Collaborator

@Simek Simek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the docs for 0.68, so this should b ready to ship.

Thank you @peterc1731, for the update in the first place! 👍

@Simek Simek merged commit c8f1a66 into facebook:main Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed 🕐 Waiting on PR These may be waiting for a PR to the facebook/react-native to be merged Wait on future Release This indicates a PR that updates the doc to match a future release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants