Skip to content

Commit

Permalink
improve CI checks, ditch test in favor of Netlify, fix Alex warnings (
Browse files Browse the repository at this point in the history
#2570)

* improve CI checks, ditch `test` in favor of Netlify, fix Alex warnings in newest blog posts

* fix SCSS, prettier blog post after Alex fixes

* break build to test the Netlify logs

* fix the invalid config

* remove commented out workflow
  • Loading branch information
Simek authored Apr 4, 2021
1 parent a88e8bc commit 8f53b0f
Show file tree
Hide file tree
Showing 8 changed files with 16 additions and 37 deletions.
4 changes: 2 additions & 2 deletions .alexignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# The Code of Conduct calls out language that can't be used so it's not linted.
CODE_OF_CONDUCT.md

# We will handle the blog posts after the main docs are linted.
website/blog/
# We will handle the older blog posts later.
website/blog/201*
31 changes: 1 addition & 30 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,31 +50,6 @@ jobs:
- ~/react-native-website

# --------------------------------------------------
# JOB: test
# Test that the website can be built.
# --------------------------------------------------
test:
executor: node
working_directory: ~/react-native-website/website
steps:
- restore_cache_checkout
- run_yarn
- run: yarn ci-check
- run: export NODE_OPTIONS=--max_old_space_size=4096
- run: export TERSER_PARALLEL=false
# Run build test only for three latest version to avoid memory issues
- run: export DEPOLY_PREVIEW=true
- run:
name: Compile website
command: yarn test
no_output_timeout: 20m
- run:
name: Check for missing index.html (build errors)
command: |
if [ ! -f build/index.html ]; then
exit 1;
fi
# --------------------------------------------------
# JOB: lint
# Lint the docs.
# --------------------------------------------------
Expand All @@ -85,6 +60,7 @@ jobs:
- restore_cache_checkout
- run_yarn
- run: yarn lint
- run: yarn prettier:diff

# -------------------------
# WORKFLOWS
Expand All @@ -95,11 +71,6 @@ workflows:
jobs:
- setup

# Run tests
- test:
requires:
- setup

# Run lints
- language_lint:
requires:
Expand Down
2 changes: 2 additions & 0 deletions website/blog/2020-03-26-version-0.62.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ tags: [announcement, release]

Today we’re releasing React Native version 0.62 which includes support for Flipper by default.

<!--alex ignore master-->

This release comes in the midst of a global pandemic. We’re releasing this version today to respect the work of hundreds of contributors who made this release possible and to prevent the release from falling too far behind master. Please be mindful of the reduced capacity of contributors to help with issues and prepare to delay upgrading if necessary.

## Flipper by default
Expand Down
4 changes: 3 additions & 1 deletion website/blog/2020-07-06-version-0.63.md
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ You can learn more about it from [the documentation](https://reactnative.dev/doc

Every native platform has the concept of system-defined colors. Colors that automatically respond to system theme settings such as Light or Dark mode, accessibility settings such as a High Contrast mode, and even its context within the app such as the traits of a containing view or window.

While it is possible to detect some of these settings via the [`Appearance`](https://reactnative.dev/docs/appearance#getcolorscheme) API and/or [`AccessibilityInfo`](https://reactnative.dev/docs/accessibilityinfo#isgrayscaleenabled) and set your styles accordingly, such abstractions are not only costly to develop but are just approximating the appearance of native colors. These inconsistencies are particularly noticeable when working on a hybrid application, where React Native elements co-exist next to the native ones.
While it is possible to detect some of these settings via the [`Appearance`](https://reactnative.dev/docs/appearance#getcolorscheme) API and/or [`AccessibilityInfo`](https://reactnative.dev/docs/accessibilityinfo#isgrayscaleenabled) and set your styles accordingly, such abstractions are not only costly to develop but are approximating the appearance of native colors. These inconsistencies are particularly noticeable when working on a hybrid application, where React Native elements co-exist next to the native ones.

React Native now provides an out-of-the-box solution to use these system colors. `PlatformColor()` is a new API that can be used like any other color in React Native.

Expand Down Expand Up @@ -150,6 +150,8 @@ At the same time, we are dropping support for Node 8. [Its LTS maintenance cycle

Thank you to the hundreds of contributors that helped make 0.63 possible!

<!--alex ignore special white-->

> Special thanks to [Rick Hanlon](https://twitter.com/rickhanlonii) for authoring the section on `LogBox` and [Eli White](https://twitter.com/Eli_White) for authoring the `Pressable` part of this article.
To see all the updates, take a look at the [0.63 changelog](https://github.com/react-native-community/releases/blob/master/CHANGELOG.md#0630).
2 changes: 1 addition & 1 deletion website/blog/2020-07-17-react-native-principles.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ Great user experiences are created iteratively. **It should only take a few seco

We often hear from teams that adopting React Native significantly improved their development velocity. These teams find that the instant feedback during development makes it much easier to try different ideas and add extra polish when they don’t have to interrupt their coding session for every little change. When we make changes to React Native, we make sure to preserve this quality of the developer experience.

Instant feedback is not the only way that React Native improves developer velocity. Teams can easily leverage the fast-growing ecosystem of high quality open source packages. Teams can also share business logic between Android, iOS, and the web. This helps them ship updates faster and reduce organizational silos between platform teams.
Instant feedback is not the only way that React Native improves developer velocity. Teams can leverage the fast-growing ecosystem of high quality open source packages. Teams can also share business logic between Android, iOS, and the web. This helps them ship updates faster and reduce organizational silos between platform teams.

## Every Platform

Expand Down
2 changes: 2 additions & 0 deletions website/blog/2021-03-12-version-0.64.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,8 @@ More information about Inline Requires is available in the [Performance document

## View Hermes traces with Chrome

<!--alex ignore fellowship-->

Over the last year Facebook has sponsored the [Major League Hacking fellowship](https://fellowship.mlh.io/), supporting contributions to React Native. [Jessie Nguyen](https://twitter.com/jessie_anh_ng) and [Saphal Patro](https://twitter.com/saphalinsaan) added the ability to use the Performance tab on Chrome DevTools to visualize the execution of your application when it is using Hermes.

For more information, check out the [new documentation page](/docs/profile-hermes#record-a-hermes-sampling-profile).
Expand Down
4 changes: 2 additions & 2 deletions website/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@
"format:style": "prettier --write src/**/*.{scss,css}",
"nit:source": "prettier --list-different {{core,src}/**/*.js,*.js}",
"nit:markdown": "prettier --list-different ../docs/*.md && prettier --list-different {{versioned_docs,src}/**/*.md,blog/*.md}",
"nit:style": "&& prettier --write src/**/*.{scss,css}",
"nit:style": "prettier --list-different src/**/*.{scss,css}",
"prettier": "yarn format:source && yarn format:markdown && yarn format:style",
"prettier:diff": "yarn nit:source",
"prettier:diff": "yarn nit:source && yarn nit:style && prettier --list-different ../docs/*.md",
"test": "yarn build",
"lint": "cd ../ && alex .",
"lintv": "cd ../ && alex",
Expand Down
4 changes: 3 additions & 1 deletion website/src/css/customTheme.scss
Original file line number Diff line number Diff line change
Expand Up @@ -1452,7 +1452,9 @@ html[data-theme="dark"] .docsRating {
border-bottom: 0.01rem solid var(--ifm-table-border-color);
}

h3, h4, li {
h3,
h4,
li {
user-select: none;
}

Expand Down

0 comments on commit 8f53b0f

Please sign in to comment.