Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Add "trace react updates" to readme #340

Merged
merged 2 commits into from
May 19, 2016
Merged

Add "trace react updates" to readme #340

merged 2 commits into from
May 19, 2016

Conversation

stipsan
Copy link
Contributor

@stipsan stipsan commented Mar 3, 2016

@jaredly something like this?

Related to #337

@jaredly
Copy link
Contributor

jaredly commented Mar 5, 2016

:) cool. For the second paragraph I'd probably instead say

Why does it trace components that don't actually update? (via shouldComponentUpdate() -> false)
This is a limitation of the system used to track updates, and will hopefully change in the future. It doesn't, however, trace the children of components that opt out, as there's no possibility of them updating.

@MatthewMiele
Copy link

@stipsan I found your commit by trying to find some more information about this feature. Specifically the colours of the box's that show who's updating. Do you know what the colour of the box represents? If so that should be added as well.

@stipsan
Copy link
Contributor Author

stipsan commented Mar 13, 2016

OK @jaredly, I'll update it.

@MatthewMiele the color range is from "cold" blue to "hot" red, corresponding to the frequency of update calls.
Cold colours means the updates are infrequent. If you see a lot of red or yellow it may indicate performance optimization is needed :)
I'll add it to the FAQ, no problem!

based on feedback
@stipsan
Copy link
Contributor Author

stipsan commented Apr 1, 2016

@jaredly @MatthewMiele updated :)

@gaearon gaearon merged commit 1497edc into facebook:master May 19, 2016
@gaearon
Copy link
Contributor

gaearon commented May 19, 2016

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants