-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rand to 0.8 and rand_core to 0.6 #103
Conversation
Hi @PaulGrandperrin! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
4d028ac
to
4c818b0
Compare
749df68
to
27cb824
Compare
897bbde
to
12b454a
Compare
a small update:
UPDATE: |
12b454a
to
17d262d
Compare
This makes better user experience when targeting wasm. Closes facebook#101
17d262d
to
e261fa0
Compare
I feel that this PR is ready for review but I am myself unsure about the move from We might get more information about the situation in response to this comment: dalek-cryptography/curve25519-dalek#338 (comment) |
e261fa0
to
b421fab
Compare
@huitseeker : Can you also take a look here and provide your thoughts on the move to |
@PaulGrandperrin, can you take a look at #131 and see if that should suffice, instead of merging this one? |
This makes a better user experience when targeting wasm.
Closes #101