TODO fixes

facebook · Apr 29, 2024 · 3b35dab · 3b35dab
1 parent 5f7e036
commit 3b35dab
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/storage/rocksdb/ha_rocksdb.cc b/storage/rocksdb/ha_rocksdb.cc
@@ -5084,10 +5084,7 @@ class Rdb_transaction_impl : public Rdb_transaction {
 
   void start_ignore_snapshot() {
     // This may be called several times for the same statement
-    if (in_snapshot_ignore_mode()) {
-      assert(m_read_opts[TABLE_TYPE::USER_TABLE].snapshot == nullptr);
-      return;
-    }
+    if (in_snapshot_ignore_mode()) return;
 
     assert(m_saved_snapshot == nullptr);
 
@@ -5303,7 +5300,7 @@ class Rdb_transaction_impl : public Rdb_transaction {
       return;
     }
 
-    if (has_snapshot(table_type)) {
+    if (!has_snapshot(table_type)) {
       const auto thd_ss = std::static_pointer_cast<Rdb_explicit_snapshot>(
           m_thd->get_explicit_snapshot());
       if (thd_ss) {

diff --git a/storage/rocksdb/rdb_vector_db.cc b/storage/rocksdb/rdb_vector_db.cc
@@ -714,7 +714,7 @@ uint create_vector_index(Rdb_cmd_srv_helper &, const std::string &,
                          const FB_vector_index_config,
                          std::shared_ptr<rocksdb::ColumnFamilyHandle>,
                          const Rdb_key_def, const Index_id,
-                         std::unique_ptr<Rdb_vector_index> &) {
+                         std::unique_ptr<Rdb_vector_index> &index) {
   index = nullptr;
   return HA_ERR_UNSUPPORTED;
 }