Bump "image-size" version 0.6.0->1.0.2 and enable KTX support #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D45563991 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D45563991 |
rshest
added a commit
to rshest/metro
that referenced
this pull request
May 6, 2023
…ort (facebook#975) Summary: Pull Request resolved: facebook#975 In this diff: * `image-size` dependency is updated from 0.6.0 (which is five years old now) to 1.0.2. The goal is the KTX support [which was added](image-size/image-size@0192f77) in v0.8.2 * Some of the relevant code that is used in `metro-buck-transform-worker` was factored back into the `metro` package - this is arguably a better encapsulation of this functionality, and also it's nice to have a single source of truth for the `image-source` dependency (because now `metro-buck-transform-worker` doesn't directly depend on it anymore) * The KTX format is actually added as supported one The net result is that metro-buck now treats KTX files as valid image assets, and processes them correctly through the remote assets bundling pipeline. Reviewed By: GijsWeterings Differential Revision: D45563991 fbshipit-source-id: 3569429c3dfab0c6547302068f66d7b08ab0028d
…ort (facebook#975) Summary: Pull Request resolved: facebook#975 In this diff: * `image-size` dependency is updated from 0.6.0 (which is five years old now) to 1.0.2. The goal is the KTX support [which was added](image-size/image-size@0192f77) in v0.8.2 * Some of the relevant code that is used in `metro-buck-transform-worker` was factored back into the `metro` package - this is arguably a better encapsulation of this functionality, and also it's nice to have a single source of truth for the `image-source` dependency (because now `metro-buck-transform-worker` doesn't directly depend on it anymore) * The KTX format is actually added as supported one The net result is that metro-buck now treats KTX files as valid image assets, and processes them correctly through the remote assets bundling pipeline. Reviewed By: GijsWeterings Differential Revision: D45563991 fbshipit-source-id: 18fa4cca7e617a1048c6770bbe1ec166396204b4
|
This pull request was exported from Phabricator. Differential Revision: D45563991 |
|
This pull request has been merged in c11f75a. |
This was referenced May 20, 2024
Open
Open
Open
Open
This was referenced May 28, 2024
Open
Open
Open
Open
Open
This was referenced Jun 5, 2024
Open
Open
This was referenced Aug 14, 2024
Open
Open
Open
This was referenced Aug 30, 2024
Open
Open
Open
This was referenced Sep 7, 2024
Open
Open
This was referenced Sep 14, 2024
This was referenced Sep 21, 2024
Open
Open
This was referenced Sep 30, 2024
Open
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In this diff:
image-sizedependency is updated from 0.6.0 (which is five years old now) to 1.0.2. The goal is the KTX support which was added in v0.8.2metro-buck-transform-workerwas factored back into themetropackage - this is arguably a better encapsulation of this functionality, and also it's nice to have a single source of truth for theimage-sourcedependency (because nowmetro-buck-transform-workerdoesn't directly depend on it anymore)The net result is that metro-buck now treats KTX files as valid image assets, and process them correctly through the remote assets bundling pipeline.
Differential Revision: D45563991