Support lazy parameter in bundle requests
#971
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D45161543 fbshipit-source-id: d30bb8035eef37a9a757b1e7bdbc90bd05a898de
Summary: Adds support for [lazy bundling](https://github.com/react-native-community/discussions-and-proposals/blob/main/proposals/0605-lazy-bundling.md) in Metro by accepting the `lazy` URL parameter in bundle requests. This replaces the old `server.experimentalImportBundleSupport` config option, which is no longer recognised. Docs for this feature will follow in a separate commit. Changelog: NOTE: We may want to group together items related to lazy bundling in this release (the first one where lazy bundling will be a stable and non-experimental feature). * **[Feature]**: Support `lazy` parameter in bundle requests. See the [lazy bundling RFC](https://github.com/react-native-community/discussions-and-proposals/blob/main/proposals/0605-lazy-bundling.md) for more details. * **[Experimental]** Removed `server.experimentalImportBundleSupport` config option. Reviewed By: huntie Differential Revision: D43600055 fbshipit-source-id: 4dbef8acf5741753d3cd1dee99c5eac302fbf66b
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D43600055 |
motiz88
added a commit
to motiz88/react-native
that referenced
this pull request
Apr 21, 2023
Summary: Pull Request resolved: facebook#37003 Changelog: [General][Added] [3/n] Support lazy bundling in development Enables [lazy bundling](https://github.com/react-native-community/discussions-and-proposals/blob/main/proposals/0605-lazy-bundling.md) when requesting a development bundle from Metro. NOTE: This depends on a Metro diff (facebook/metro#971) that hasn't landed yet, but is a no-op until then. Reviewed By: jacdebug Differential Revision: D43600054 fbshipit-source-id: db0292a1b33ff1a7b14ba7f9523ccbed23783a06
motiz88
added a commit
to motiz88/react-native
that referenced
this pull request
Apr 24, 2023
Summary: Pull Request resolved: facebook#37003 Changelog: [General][Added] [3/n] Support lazy bundling in development Enables [lazy bundling](https://github.com/react-native-community/discussions-and-proposals/blob/main/proposals/0605-lazy-bundling.md) when requesting a development bundle from Metro. NOTE: This depends on a Metro diff (facebook/metro#971) that hasn't landed yet, but is a no-op until then. Reviewed By: jacdebug Differential Revision: D43600054 fbshipit-source-id: b7592c452520ade4e5ff9ee0fa0742189625b390
|
This pull request has been merged in 4ef14f9. |
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Apr 24, 2023
Summary: Pull Request resolved: #37003 Changelog: [General][Added] [3/n] Support lazy bundling in development Enables [lazy bundling](https://github.com/react-native-community/discussions-and-proposals/blob/main/proposals/0605-lazy-bundling.md) when requesting a development bundle from Metro. NOTE: This depends on a Metro diff (facebook/metro#971) that hasn't landed yet, but is a no-op until then. Reviewed By: jacdebug Differential Revision: D43600054 fbshipit-source-id: 515e2180a2130fd1a75e53677e789d31a367f7c2
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
Summary: Pull Request resolved: facebook#37003 Changelog: [General][Added] [3/n] Support lazy bundling in development Enables [lazy bundling](https://github.com/react-native-community/discussions-and-proposals/blob/main/proposals/0605-lazy-bundling.md) when requesting a development bundle from Metro. NOTE: This depends on a Metro diff (facebook/metro#971) that hasn't landed yet, but is a no-op until then. Reviewed By: jacdebug Differential Revision: D43600054 fbshipit-source-id: 515e2180a2130fd1a75e53677e789d31a367f7c2
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#37003 Changelog: [General][Added] [3/n] Support lazy bundling in development Enables [lazy bundling](https://github.com/react-native-community/discussions-and-proposals/blob/main/proposals/0605-lazy-bundling.md) when requesting a development bundle from Metro. NOTE: This depends on a Metro diff (facebook/metro#971) that hasn't landed yet, but is a no-op until then. Reviewed By: jacdebug Differential Revision: D43600054 fbshipit-source-id: 515e2180a2130fd1a75e53677e789d31a367f7c2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adds support for lazy bundling in Metro by accepting the
lazyURL parameter in bundle requests. This replaces the oldserver.experimentalImportBundleSupportconfig option, which is no longer recognised.Docs for this feature will follow in a separate commit.
Changelog:
NOTE: We may want to group together items related to lazy bundling in this release (the first one where lazy bundling will be a stable and non-experimental feature).
lazyparameter in bundle requests. See the lazy bundling RFC for more details.server.experimentalImportBundleSupportconfig option.Reviewed By: huntie
Differential Revision: D43600055