Resolver perf: Optimise package exports flattenLegacySubpathValues (1/n)
#1318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D56701232 |
…(1/n) (#1318) Summary: Pull Request resolved: #1318 The performance results from this stack are based on replaying the ~3000 resolutions performed during bundling RN Tester directly through `DependencyGraph.resolveDependency`. The baseline resolution time is ~1500ms on an M1 Max. (Internal: details in test plan) This is a self-contained optimsation to the `flattenLegacySubpathValues` step as part of exports map normalisation, which takes over 20% (360ms) of total resolver CPU time over 655 calls due largely to repeated object allocations and spreads. By mutating an intermediate object instead we get this down to ~16ms. Note that this still preserves key order - export maps are ordered. This reduces total resolution time from 1540ms -> 1171ms (-23%) Reviewed By: huntie Differential Revision: D56701232
|
This pull request was exported from Phabricator. Differential Revision: D56701232 |
robhogan
force-pushed
the
export-D56701232
branch
from
ddcdb13 to
0c4d257
Compare
|
This pull request has been merged in 021e890. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The performance results from this stack are based on replaying the ~3000 resolutions performed during bundling RN Tester directly through
DependencyGraph.resolveDependency. The baseline resolution time is ~1500ms on an M1 Max. (Internal: details in test plan)This is a self-contained optimsation to the
flattenLegacySubpathValuesstep as part of exports map normalisation, which takes over 20% (360ms) of total resolver CPU time over 655 calls due largely to repeated object allocations and spreads. By mutating an intermediate object instead we get this down to ~16ms.Note that this still preserves key order - export maps are ordered.
This reduces total resolution time from 1540ms -> 1171ms (-23%)
Differential Revision: D56701232