fix(#1167): function calls prefixed with void together with the optional chain (?.) are skipped
#1178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the optional chain (?.) are skipped
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
This update includes the NodePath<BabelNodeOptionalCallExpression> as part of the paths considered unsafe.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1178 +/- ##
=======================================
Coverage 83.31% 83.31%
=======================================
Files 207 207
Lines 10633 10633
Branches 2642 2642
=======================================
Hits 8859 8859
Misses 1774 1774 ☔ View full report in Codecov by Sentry. |
Gamote
changed the title
void together with the optional chain (?.) are skippedvoid together with the optional chain (?.) are skipped on production (dev: false).
Gamote
changed the title
void together with the optional chain (?.) are skipped on production (dev: false).void together with the optional chain (?.) are skipped
|
@robhogan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This is a great catch @Gamote - thanks for the fix! (To follow up, we ought to invert this logic so that nodes are default unsafe.) |
robhogan
approved these changes
Jan 15, 2024
@robhogan Is there anything specific that I can do to fix this? |
Thanks, but nothing's broken, just a couple of flaky tests. We're just waiting for internal review at the moment, shouldn't be long. |
Ah alright. Thank you for the information. |
Merged
robhogan
pushed a commit
that referenced
this pull request
Jan 29, 2024
…ional chain (?.) are skipped (#1178) Summary: Fixes: #1167 `constant-folding-plugin` replaces this call `void foo?.();` with `undefined;`. This is because the `evaluate()` function marks the optional call expressions as safe, making the `UnaryExpression` visitor think it is safe to replace it with the `value` returned by the `evaluate()`, in this case `undefined`. This PR makes the `evaluate()` function mark the optional call expressions as unsafe. ``` * **[Fix]**: `constant-folding-plugin`: Don't fold optional function calls (`foo.?()`). ``` Pull Request resolved: #1178 Test Plan: I have added 2 tests to cover these changes: - does not transform optional chained call into `undefined` - does not transform `void` prefixed optional chained call into `undefined` Reviewed By: GijsWeterings Differential Revision: D52780448 Pulled By: robhogan fbshipit-source-id: c84288adc1fec6c2e875fd766c5a6b0997a36c62
robhogan
pushed a commit
that referenced
this pull request
Jan 30, 2024
…ional chain (?.) are skipped (#1178) Summary: Fixes: #1167 `constant-folding-plugin` replaces this call `void foo?.();` with `undefined;`. This is because the `evaluate()` function marks the optional call expressions as safe, making the `UnaryExpression` visitor think it is safe to replace it with the `value` returned by the `evaluate()`, in this case `undefined`. This PR makes the `evaluate()` function mark the optional call expressions as unsafe. ``` * **[Fix]**: `constant-folding-plugin`: Don't fold optional function calls (`foo.?()`). ``` Pull Request resolved: #1178 Test Plan: I have added 2 tests to cover these changes: - does not transform optional chained call into `undefined` - does not transform `void` prefixed optional chained call into `undefined` Reviewed By: GijsWeterings Differential Revision: D52780448 Pulled By: robhogan fbshipit-source-id: c84288adc1fec6c2e875fd766c5a6b0997a36c62
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #1167
constant-folding-pluginreplaces this callvoid foo?.();withundefined;.This is because the
evaluate()function marks the optional call expressions as safe, making theUnaryExpressionvisitor think it is safe to replace it with thevaluereturned by theevaluate(), in this caseundefined.This PR makes the
evaluate()function mark the optional call expressions as unsafe.Changelog:
Test plan
I have added 2 tests to cover these changes:
undefinedvoidprefixed optional chained call intoundefined