Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle mutations with text entry time stamps #794

Merged
merged 1 commit into from
Nov 3, 2021

Conversation

trueadm
Copy link
Collaborator

@trueadm trueadm commented Nov 3, 2021

It turns out that our previous heuristic of capturing mutations during the capture phase of the input event does not suffice. On Safari, if you open dev tools, mutation observers always happen before even a capture input. Instead we now use the textInput time stamp to give signal to when we're typing and thus can ignore some text mutations entirely.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 3, 2021
@trueadm trueadm merged commit fa39723 into main Nov 3, 2021
@trueadm trueadm deleted the alternative-mutation-pattern branch November 3, 2021 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants