Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lexical-playground] Fix: Hidden comment button on narrow screens or vertical monitors #6871

Merged
merged 2 commits into from
Nov 28, 2024
Merged

[lexical-playground] Fix: Hidden comment button on narrow screens or vertical monitors #6871

merged 2 commits into from
Nov 28, 2024

Conversation

vantage-ola
Copy link
Contributor

Description

CommentPlugin_AddCommentBox and .CommentPlugin_ShowCommentBox width was reduced to 600px from 1024px to accomodate more vertical/narrower and smaller screens

Screenshot 2024-11-26 170332

@vercel Vercel
Copy link

vercel bot commented Nov 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2024 5:28am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2024 5:28am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 26, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 26, 2024 •
edited
Loading

size-limit report 📦

Path Size
lexical - cjs 30.91 KB (0%)
lexical - esm 30.79 KB (0%)
@lexical/rich-text - cjs 39.67 KB (0%)
@lexical/rich-text - esm 32.65 KB (0%)
@lexical/plain-text - cjs 38.27 KB (0%)
@lexical/plain-text - esm 29.93 KB (0%)
@lexical/react - cjs 41.4 KB (0%)
@lexical/react - esm 34 KB (0%)

potatowagon
potatowagon approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@potatowagon potatowagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, the advantage of this change is the comment buttons will still show up to small screen sizes of 600px

@etrepum etrepum added this pull request to the merge queue Nov 28, 2024
Merged via the queue into facebook:main with commit 805215b Nov 28, 2024
11 checks passed
@vantage-ola vantage-ola deleted the fix-hidden-comment branch November 28, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potatowagon potatowagon potatowagon approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

@Sahejkm Sahejkm Awaiting requested review from Sahejkm Sahejkm is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vantage-ola @potatowagon @etrepum @facebook-github-bot