Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[*] Feature: Check undeclared dependencies in build #6574

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

etrepum
Copy link
Collaborator

@etrepum etrepum commented Aug 28, 2024

Description

It's easy to add inter-package dependencies in the monorepo that can cause problems for npm users.

Closes #6572

Test plan

Before

Packages could have undeclared inter-package dependencies that go unchecked

After

The build fails when these inter-package dependencies are not declared

❯ npm run build

> @lexical/[email protected] build
> node scripts/build.js

Error: packages/lexical-yjs/src/SyncCursors.ts has an undeclared dependency in its import of @lexical/selection.
Add the following to the dependencies in packages/lexical-yjs/package.json: "@lexical/selection": "0.17.1"

Copy link

vercel bot commented Aug 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2024 7:10pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2024 7:10pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 28, 2024
@etrepum etrepum marked this pull request as ready for review August 28, 2024 19:09
@etrepum etrepum added the extended-tests Run extended e2e tests on a PR label Aug 28, 2024
Copy link

github-actions bot commented Aug 28, 2024

size-limit report 📦

Path Size
lexical - cjs 29.38 KB (0%)
lexical - esm 29.22 KB (0%)
@lexical/rich-text - cjs 37.87 KB (0%)
@lexical/rich-text - esm 31.08 KB (0%)
@lexical/plain-text - cjs 36.45 KB (0%)
@lexical/plain-text - esm 28.44 KB (0%)
@lexical/react - cjs 39.64 KB (0%)
@lexical/react - esm 32.52 KB (0%)

@etrepum etrepum added this pull request to the merge queue Aug 28, 2024
Merged via the queue into facebook:main with commit 1f778da Aug 28, 2024
43 checks passed
@etrepum etrepum deleted the check-undeclared-dependencies branch August 28, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add tests to ensure that all inter-package dependencies are declared
3 participants