Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deletion when table in selection #6471

Closed
wants to merge 1 commit into from
Closed

Fix deletion when table in selection #6471

wants to merge 1 commit into from

Conversation

ivailop7
Copy link
Collaborator

Attempt to fix selection deletion, when a table in in the selection

@vercel Vercel
Copy link

vercel bot commented Jul 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 27, 2024 11:39pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 27, 2024 11:39pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 27, 2024
@github-actions GitHub Actions
Copy link

size-limit report 📦

Path Size
lexical - cjs 29.05 KB (0%)
lexical - esm 28.86 KB (0%)
@lexical/rich-text - cjs 37.39 KB (0%)
@lexical/rich-text - esm 28.33 KB (0%)
@lexical/plain-text - cjs 36.02 KB (0%)
@lexical/plain-text - esm 25.6 KB (0%)
@lexical/react - cjs 39.29 KB (0%)
@lexical/react - esm 29.77 KB (0%)

@ivailop7 ivailop7 mentioned this pull request Jul 27, 2024
Merged
@ivailop7 ivailop7 changed the title Fix Deletion when table in selection Fix deletion when table in selection Jul 27, 2024
@ivailop7 ivailop7 added the extended-tests Run extended e2e tests on a PR label Jul 27, 2024
@ivailop7 ivailop7 marked this pull request as draft July 27, 2024 23:47
@ivailop7 ivailop7 closed this Jul 28, 2024
@ivailop7 ivailop7 deleted the fix_typing_over_add_buttons branch July 28, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@Sahejkm Sahejkm Awaiting requested review from Sahejkm Sahejkm is a code owner

@potatowagon potatowagon Awaiting requested review from potatowagon potatowagon is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivailop7 @facebook-github-bot