[lexical] Bug Fix: getCachedTypeToNodeMap should handle a empty and writable EditorState #6444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
size-limit report 📦
|
etrepum
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
ivailop7,
Sahejkm and
potatowagon
as code owners
etrepum
commented
Jul 23, 2024
| @@ -903,7 +903,7 @@ export class LexicalEditor { | |||
| klass: Klass<LexicalNode>, | |||
| ): void { | |||
| const prevEditorState = this._editorState; | |||
| const nodeMap = getCachedTypeToNodeMap(this._editorState).get( | |||
| const nodeMap = getCachedTypeToNodeMap(prevEditorState).get( | |||
There was a problem hiding this comment.
not a meaningful change but should optimize better
zurfyx
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #6357
When an editor is still initializing the this._editorState may be writable but will only have the 'root' entry. We need to special case this to prevent an exception if a mutation listener with initialization is registered before the first reconciliation.
Test plan
The unit test covers this case and will fail without the change