Change notification to be transient (notify-send)

[BudgieInWA]

Summary

Under GNOME Shell, using --notify (especially with --watch) floods the notification UI with unnecessary persistent copies of each notification that is raised. This PR aims to close #8773.

Test plan

I have only tested this under GNOME shell on Ubuntu. Run jest --notify or jest --watch --notify and observe that the raised notifications are not added to the notification area.

Judging by the use of the existing usage of the actions argument to require('node-notifier').notify, it is safe to pass this argument on all platforms, but I have not tested it.

[facebook-github-bot]

Hi @BudgieInWA!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[SimenB]

Thanks for the PR!

@mikaelbr does this look correct?

[SimenB]

@mikaelbr would love a confirmation 🙏

[mikaelbr]

This seems reasonable to me! Haven't been able to test it out on a UNIX box my self now (no immediate access), but from docs and examples, this makes sense.

[SimenB]

Great, thanks @mikaelbr!

[SimenB]

thanks!

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.