-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docusaurus2 Migration #582
Conversation
@yangshun there is still an issue where the test-execution doc page sidebar is showing at the bottom of the page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@c-ryan747 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general, just some suggestions for improvements!
1. Renamed docs to mdx and used useBaseUrl for image 2. Moved image from docs folder to to website/static/img folder 3. Removed outdated header comment from docusaurus.config.js 4. Upgraded docusaurus/preset-classic to ^2.0.0-alpha.43 5. Added copyright header to website/src/custom.css
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@c-ryan747 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@c-ryan747 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
@scottilee merged this pull request in 8917bd6. |
Motivation
Migrates idb website to Docusaurus v2. This issue has more information. Additionally, there are some doc fixes.
Fixes #564
Test Plan
Try it out here: https://idb.scottlee.now.sh
v2 screenshot:

Related PRs
N/A
/cc @yangshun