Skip to content

Commit

Permalink
Remove Shims from FBTestLaunchConfiguration
Browse files Browse the repository at this point in the history
Summary:
There was only a single place where this was needed, and that was in the xcodebuild based execution.

Here we can just make it an explicit parameter, and only when simulators w/ a custom device set are used.

Reviewed By: jamescoggan

Differential Revision: D29515500

fbshipit-source-id: d9bafc10bdfce4ef3c81489cb8dc3fd5b56cc63d
  • Loading branch information
lawrencelomax authored and facebook-github-bot committed Jul 8, 2021
1 parent f04e95d commit ec1d271
Show file tree
Hide file tree
Showing 14 changed files with 41 additions and 51 deletions.
8 changes: 1 addition & 7 deletions FBControlCore/Configuration/FBTestLaunchConfiguration.h
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
NS_ASSUME_NONNULL_BEGIN

@class FBApplicationLaunchConfiguration;
@class FBXCTestShimConfiguration;

/**
A Value object with the information required to launch a XCTest.
Expand All @@ -22,7 +21,7 @@ NS_ASSUME_NONNULL_BEGIN
/**
The Designated Initializer
*/
- (instancetype)initWithTestBundlePath:(NSString *)testBundlePath applicationLaunchConfiguration:(FBApplicationLaunchConfiguration *)applicationLaunchConfiguration testHostPath:(nullable NSString *)testHostPath timeout:(NSTimeInterval)timeout initializeUITesting:(BOOL)initializeUITesting useXcodebuild:(BOOL)useXcodebuild testsToRun:(nullable NSSet<NSString *> *)testsToRun testsToSkip:(nullable NSSet<NSString *> *)testsToSkip targetApplicationPath:(nullable NSString *)targetApplicationPath targetApplicationBundleID:(nullable NSString *)targetApplicaitonBundleID xcTestRunProperties:(nullable NSDictionary *)xcTestRunProperties resultBundlePath:(nullable NSString *)resultBundlePath reportActivities:(BOOL)reportActivities coveragePath:(nullable NSString *)coveragePath logDirectoryPath:(nullable NSString *)logDirectoryPath shims:(nullable FBXCTestShimConfiguration *)shims;
- (instancetype)initWithTestBundlePath:(NSString *)testBundlePath applicationLaunchConfiguration:(FBApplicationLaunchConfiguration *)applicationLaunchConfiguration testHostPath:(nullable NSString *)testHostPath timeout:(NSTimeInterval)timeout initializeUITesting:(BOOL)initializeUITesting useXcodebuild:(BOOL)useXcodebuild testsToRun:(nullable NSSet<NSString *> *)testsToRun testsToSkip:(nullable NSSet<NSString *> *)testsToSkip targetApplicationPath:(nullable NSString *)targetApplicationPath targetApplicationBundleID:(nullable NSString *)targetApplicaitonBundleID xcTestRunProperties:(nullable NSDictionary *)xcTestRunProperties resultBundlePath:(nullable NSString *)resultBundlePath reportActivities:(BOOL)reportActivities coveragePath:(nullable NSString *)coveragePath logDirectoryPath:(nullable NSString *)logDirectoryPath;

/**
Path to XCTest bundle used for testing
Expand Down Expand Up @@ -99,11 +98,6 @@ NS_ASSUME_NONNULL_BEGIN
*/
@property (nonatomic, nullable, copy, readonly) NSString *logDirectoryPath;

/**
Shims to be applied to test execution
*/
@property (nonatomic, copy, readonly, nullable) FBXCTestShimConfiguration *shims;

@end

NS_ASSUME_NONNULL_END
11 changes: 4 additions & 7 deletions FBControlCore/Configuration/FBTestLaunchConfiguration.m
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

@implementation FBTestLaunchConfiguration

- (instancetype)initWithTestBundlePath:(NSString *)testBundlePath applicationLaunchConfiguration:(FBApplicationLaunchConfiguration *)applicationLaunchConfiguration testHostPath:(NSString *)testHostPath timeout:(NSTimeInterval)timeout initializeUITesting:(BOOL)initializeUITesting useXcodebuild:(BOOL)useXcodebuild testsToRun:(NSSet<NSString *> *)testsToRun testsToSkip:(NSSet<NSString *> *)testsToSkip targetApplicationPath:(NSString *)targetApplicationPath targetApplicationBundleID:(NSString *)targetApplicaitonBundleID xcTestRunProperties:(NSDictionary *)xcTestRunProperties resultBundlePath:(NSString *)resultBundlePath reportActivities:(BOOL)reportActivities coveragePath:(NSString *)coveragePath logDirectoryPath:(nullable NSString *)logDirectoryPath shims:(FBXCTestShimConfiguration *)shims
- (instancetype)initWithTestBundlePath:(NSString *)testBundlePath applicationLaunchConfiguration:(FBApplicationLaunchConfiguration *)applicationLaunchConfiguration testHostPath:(NSString *)testHostPath timeout:(NSTimeInterval)timeout initializeUITesting:(BOOL)initializeUITesting useXcodebuild:(BOOL)useXcodebuild testsToRun:(NSSet<NSString *> *)testsToRun testsToSkip:(NSSet<NSString *> *)testsToSkip targetApplicationPath:(NSString *)targetApplicationPath targetApplicationBundleID:(NSString *)targetApplicaitonBundleID xcTestRunProperties:(NSDictionary *)xcTestRunProperties resultBundlePath:(NSString *)resultBundlePath reportActivities:(BOOL)reportActivities coveragePath:(NSString *)coveragePath logDirectoryPath:(nullable NSString *)logDirectoryPath
{
self = [super init];
if (!self) {
Expand All @@ -39,7 +39,6 @@ - (instancetype)initWithTestBundlePath:(NSString *)testBundlePath applicationLau
_reportActivities = reportActivities;
_coveragePath = coveragePath;
_logDirectoryPath = logDirectoryPath;
_shims = shims;

return self;
}
Expand All @@ -61,7 +60,6 @@ - (BOOL)isEqual:(FBTestLaunchConfiguration *)configuration

return (self.testBundlePath == configuration.testBundlePath || [self.testBundlePath isEqualToString:configuration.testBundlePath]) &&
(self.applicationLaunchConfiguration == configuration.applicationLaunchConfiguration || [self.applicationLaunchConfiguration isEqual:configuration.applicationLaunchConfiguration]) &&
(self.shims == configuration.shims || [self.shims isEqual:configuration.shims]) &&
(self.testHostPath == configuration.testHostPath || [self.testHostPath isEqualToString:configuration.testHostPath]) &&
(self.targetApplicationBundleID == configuration.targetApplicationBundleID || [self.targetApplicationBundleID isEqualToString:configuration.targetApplicationBundleID]) &&
(self.targetApplicationPath == configuration.targetApplicationPath || [self.targetApplicationPath isEqualToString:configuration.targetApplicationPath]) &&
Expand All @@ -78,13 +76,13 @@ - (BOOL)isEqual:(FBTestLaunchConfiguration *)configuration

- (NSUInteger)hash
{
return self.testBundlePath.hash ^ self.applicationLaunchConfiguration.hash ^ self.testHostPath.hash ^ (unsigned long) self.timeout ^ (unsigned long) self.shouldInitializeUITesting ^ (unsigned long) self.shouldUseXcodebuild ^ self.testsToRun.hash ^ self.testsToSkip.hash ^ self.targetApplicationPath.hash ^ self.targetApplicationBundleID.hash ^ self.xcTestRunProperties.hash ^ self.resultBundlePath.hash ^ self.coveragePath.hash ^ self.logDirectoryPath.hash ^ self.shims.hash;
return self.testBundlePath.hash ^ self.applicationLaunchConfiguration.hash ^ self.testHostPath.hash ^ (unsigned long) self.timeout ^ (unsigned long) self.shouldInitializeUITesting ^ (unsigned long) self.shouldUseXcodebuild ^ self.testsToRun.hash ^ self.testsToSkip.hash ^ self.targetApplicationPath.hash ^ self.targetApplicationBundleID.hash ^ self.xcTestRunProperties.hash ^ self.resultBundlePath.hash ^ self.coveragePath.hash ^ self.logDirectoryPath.hash;
}

- (NSString *)description
{
return [NSString stringWithFormat:
@"FBTestLaunchConfiguration TestBundlePath %@ | AppConfig %@ | HostPath %@ | UITesting %d | UseXcodebuild %d | TestsToRun %@ | TestsToSkip %@ | Target application path %@ | Target application bundle id %@ xcTestRunProperties %@ | ResultBundlePath %@ | CollectCoverage %@ | LogDirectoryPath %@ | Shims %@" ,
@"FBTestLaunchConfiguration TestBundlePath %@ | AppConfig %@ | HostPath %@ | UITesting %d | UseXcodebuild %d | TestsToRun %@ | TestsToSkip %@ | Target application path %@ | Target application bundle id %@ xcTestRunProperties %@ | ResultBundlePath %@ | CollectCoverage %@ | LogDirectoryPath %@" ,
self.testBundlePath,
self.applicationLaunchConfiguration,
self.testHostPath,
Expand All @@ -97,8 +95,7 @@ - (NSString *)description
self.xcTestRunProperties,
self.resultBundlePath,
self.coveragePath,
self.logDirectoryPath,
self.shims
self.logDirectoryPath
];
}

Expand Down
4 changes: 2 additions & 2 deletions FBControlCore/Configuration/FBXCTraceConfiguration.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@

#import <Foundation/Foundation.h>

#import "FBXCTestShimConfiguration.h"

NS_ASSUME_NONNULL_BEGIN

@class FBXCTestShimConfiguration;

/**
A Value object with the information required to run `xctrace record`
*/
Expand Down
5 changes: 3 additions & 2 deletions FBControlCore/Utility/FBXCTraceOperation.m
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,12 @@
#import "FBControlCoreLogger.h"
#import "FBDataConsumer.h"
#import "FBFuture.h"
#import "FBXcodeConfiguration.h"
#import "FBXCTraceConfiguration.h"
#import "FBiOSTarget.h"
#import "FBTask+Helpers.h"
#import "FBTaskBuilder.h"
#import "FBXcodeConfiguration.h"
#import "FBXCTestShimConfiguration.h"
#import "FBXCTraceConfiguration.h"

const NSTimeInterval DefaultXCTraceRecordOperationTimeLimit = 4 * 60 * 60; // 4h
const NSTimeInterval DefaultXCTraceRecordStopTimeout = 600.0; // 600s
Expand Down
1 change: 1 addition & 0 deletions FBDeviceControl/Commands/FBDeviceXCTestCommands.m
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ - (instancetype)initWithDevice:(FBDevice *)device workingDirectory:(NSString *)w
xcodeBuildPath:xcodeBuildPath
testRunFilePath:filePath
simDeviceSet:nil
macOSTestShimPath:nil
queue:self.device.workQueue
logger:[logger withName:@"xcodebuild"]];
}
Expand Down
4 changes: 2 additions & 2 deletions FBSimulatorControl.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@
AA5449951CFF4A6700443C2F /* FBiOSTargetConfiguration.h in Headers */ = {isa = PBXBuildFile; fileRef = AA5449931CFF4A6700443C2F /* FBiOSTargetConfiguration.h */; settings = {ATTRIBUTES = (Public, ); }; };
AA5449961CFF4A6700443C2F /* FBiOSTargetConfiguration.m in Sources */ = {isa = PBXBuildFile; fileRef = AA5449941CFF4A6700443C2F /* FBiOSTargetConfiguration.m */; };
AA54EC7D25ED4C6200FAA59E /* FBProcessSpawnCommands.h in Headers */ = {isa = PBXBuildFile; fileRef = AA54EC7C25ED4C6200FAA59E /* FBProcessSpawnCommands.h */; settings = {ATTRIBUTES = (Public, ); }; };
AA5639551C060005009BAFAA /* FBSimulatorControl.h in Headers */ = {isa = PBXBuildFile; fileRef = AA5639541C05FFF5009BAFAA /* FBSimulatorControl.h */; };
AA5639551C060005009BAFAA /* FBSimulatorControl.h in Headers */ = {isa = PBXBuildFile; fileRef = AA5639541C05FFF5009BAFAA /* FBSimulatorControl.h */; settings = {ATTRIBUTES = (Public, ); }; };
AA56445E1E5F6ED0006C1077 /* FBSimulatorKeychainCommands.h in Headers */ = {isa = PBXBuildFile; fileRef = AA56445C1E5F6ED0006C1077 /* FBSimulatorKeychainCommands.h */; settings = {ATTRIBUTES = (Public, ); }; };
AA56445F1E5F6ED0006C1077 /* FBSimulatorKeychainCommands.m in Sources */ = {isa = PBXBuildFile; fileRef = AA56445D1E5F6ED0006C1077 /* FBSimulatorKeychainCommands.m */; };
AA56EAF01EEFCA400062C2BC /* libMaculator.dylib in Resources */ = {isa = PBXBuildFile; fileRef = AA56EAEE1EEFCA340062C2BC /* libMaculator.dylib */; };
Expand Down Expand Up @@ -421,7 +421,7 @@
AACC503C1EAA230F0034A987 /* FBVideoStreamConfiguration.h in Headers */ = {isa = PBXBuildFile; fileRef = AACC503A1EAA230F0034A987 /* FBVideoStreamConfiguration.h */; settings = {ATTRIBUTES = (Public, ); }; };
AACC503D1EAA230F0034A987 /* FBVideoStreamConfiguration.m in Sources */ = {isa = PBXBuildFile; fileRef = AACC503B1EAA230F0034A987 /* FBVideoStreamConfiguration.m */; };
AAD064AC25E3FA9D00FCFC7F /* FBXCTestReporterDouble.m in Sources */ = {isa = PBXBuildFile; fileRef = AAD064AB25E3FA9D00FCFC7F /* FBXCTestReporterDouble.m */; };
AAD288011D586D6C00981DFC /* FBSimulatorSubprocessTerminationStrategy.h in Headers */ = {isa = PBXBuildFile; fileRef = AAD287FF1D586D6C00981DFC /* FBSimulatorSubprocessTerminationStrategy.h */; settings = {ATTRIBUTES = (Public, ); }; };
AAD288011D586D6C00981DFC /* FBSimulatorSubprocessTerminationStrategy.h in Headers */ = {isa = PBXBuildFile; fileRef = AAD287FF1D586D6C00981DFC /* FBSimulatorSubprocessTerminationStrategy.h */; };
AAD288021D586D6C00981DFC /* FBSimulatorSubprocessTerminationStrategy.m in Sources */ = {isa = PBXBuildFile; fileRef = AAD288001D586D6C00981DFC /* FBSimulatorSubprocessTerminationStrategy.m */; };
AAD305201BD4D5B10047376E /* photo1.png in Resources */ = {isa = PBXBuildFile; fileRef = AAD3051E1BD4D5B10047376E /* photo1.png */; };
AAD4B11F24892F350021487B /* FBAMDeviceManager.h in Headers */ = {isa = PBXBuildFile; fileRef = AAD4B11D24892F350021487B /* FBAMDeviceManager.h */; };
Expand Down
21 changes: 13 additions & 8 deletions FBSimulatorControl/Commands/FBSimulatorXCTestCommands.m
Original file line number Diff line number Diff line change
Expand Up @@ -203,14 +203,19 @@ - (NSString *)xctestPath
return [FBSimulatorError failFutureWithError:error];
}

return [FBXcodeBuildOperation
operationWithUDID:self.simulator.udid
configuration:configuration
xcodeBuildPath:xcodeBuildPath
testRunFilePath:filePath
simDeviceSet:self.simulator.customDeviceSetPath
queue:self.simulator.workQueue
logger:[logger withName:@"xcodebuild"]];
return [[FBXCTestShimConfiguration
defaultShimConfigurationWithLogger:self.simulator.logger]
onQueue:self.simulator.asyncQueue fmap:^(FBXCTestShimConfiguration *shims) {
return [FBXcodeBuildOperation
operationWithUDID:self.simulator.udid
configuration:configuration
xcodeBuildPath:xcodeBuildPath
testRunFilePath:filePath
simDeviceSet:self.simulator.customDeviceSetPath
macOSTestShimPath:shims.macOSTestShimPath
queue:self.simulator.workQueue
logger:[logger withName:@"xcodebuild"]];
}];
}

- (FBFuture<NSNull * > *)_testOperationStarted:(FBTask *)task configuration:(FBTestLaunchConfiguration *)configuration reporter:(id<FBXCTestReporter>)reporter logger:(id<FBControlCoreLogger>)logger
Expand Down
6 changes: 2 additions & 4 deletions FBSimulatorControlTests/Fixtures/FBSimulatorControlFixtures.m
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,7 @@ - (FBTestLaunchConfiguration *)testLaunchTableSearch
resultBundlePath:nil
reportActivities:NO
coveragePath:nil
logDirectoryPath:nil
shims:nil];
logDirectoryPath:nil];
}

- (FBTestLaunchConfiguration *)testLaunchSafari
Expand All @@ -93,8 +92,7 @@ - (FBTestLaunchConfiguration *)testLaunchSafari
resultBundlePath:nil
reportActivities:NO
coveragePath:nil
logDirectoryPath:nil
shims:nil];
logDirectoryPath:nil];
}

- (FBBundleDescriptor *)tableSearchApplication
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,7 @@ - (void)testInjectsApplicationTestWithCustomOutputConfiguration
resultBundlePath:nil
reportActivities:NO
coveragePath:nil
logDirectoryPath:nil
shims:nil];
logDirectoryPath:nil];

FBSimulator *simulator = [self assertObtainsBootedSimulator];
[self assertLaunchesTestWithConfiguration:testLaunch reporter:self simulator:simulator];
Expand Down Expand Up @@ -145,8 +144,7 @@ - (void)testInjectsApplicationTestWithTestsToRun
resultBundlePath:nil
reportActivities:NO
coveragePath:nil
logDirectoryPath:nil
shims:nil];
logDirectoryPath:nil];

[self assertLaunchesTestWithConfiguration:testLaunch reporter:self simulator:simulator];
[self assertPassed:@[@"testIsRunningOnIOS"]
Expand All @@ -171,8 +169,7 @@ - (void)testInjectsApplicationTestWithTestsToSkip
resultBundlePath:nil
reportActivities:NO
coveragePath:nil
logDirectoryPath:nil
shims:nil];
logDirectoryPath:nil];

[self assertLaunchesTestWithConfiguration:testLaunch reporter:self simulator:simulator];
[self assertPassed:@[@"testIsRunningInIOSApp", @"testHostProcessIsMobileSafari", @"testPossibleCrashingOfHostProcess", @"testPossibleStallingOfHostProcess", @"testWillAlwaysPass"]
Expand Down
3 changes: 2 additions & 1 deletion XCTestBootstrap/Utility/FBXcodeBuildOperation.h
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,12 @@ NS_ASSUME_NONNULL_BEGIN
@param xcodeBuildPath the path to xcodebuild.
@param testRunFilePath the path to the xcodebuild.xctestrun file
@param simDeviceSetPath an optional path to the simulator device set
@param macOSTestShimPath this should be provided if simDeviceSetPath is non-nil
@param queue the queue to use for serialization.
@param logger the logger to log to.
@return a future that resolves when the task has launched.
*/
+ (FBFuture<FBTask *> *)operationWithUDID:(NSString *)udid configuration:(FBTestLaunchConfiguration *)configuration xcodeBuildPath:(NSString *)xcodeBuildPath testRunFilePath:(NSString *)testRunFilePath simDeviceSet:(nullable NSString *)simDeviceSetPath queue:(dispatch_queue_t)queue logger:(nullable id<FBControlCoreLogger>)logger;
+ (FBFuture<FBTask *> *)operationWithUDID:(NSString *)udid configuration:(FBTestLaunchConfiguration *)configuration xcodeBuildPath:(NSString *)xcodeBuildPath testRunFilePath:(NSString *)testRunFilePath simDeviceSet:(nullable NSString *)simDeviceSetPath macOSTestShimPath:(nullable NSString *)macOSTestShimPath queue:(dispatch_queue_t)queue logger:(nullable id<FBControlCoreLogger>)logger;

#pragma mark Public Methods

Expand Down
8 changes: 4 additions & 4 deletions XCTestBootstrap/Utility/FBXcodeBuildOperation.m
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

@implementation FBXcodeBuildOperation

+ (FBFuture<FBTask *> *)operationWithUDID:(NSString *)udid configuration:(FBTestLaunchConfiguration *)configuration xcodeBuildPath:(NSString *)xcodeBuildPath testRunFilePath:(NSString *)testRunFilePath simDeviceSet:(nullable NSString *)simDeviceSetPath queue:(dispatch_queue_t)queue logger:(nullable id<FBControlCoreLogger>)logger
+ (FBFuture<FBTask *> *)operationWithUDID:(NSString *)udid configuration:(FBTestLaunchConfiguration *)configuration xcodeBuildPath:(NSString *)xcodeBuildPath testRunFilePath:(NSString *)testRunFilePath simDeviceSet:(NSString *)simDeviceSetPath macOSTestShimPath:(NSString *)macOSTestShimPath queue:(dispatch_queue_t)queue logger:(nullable id<FBControlCoreLogger>)logger
{
NSMutableArray<NSString *> *arguments = [[NSMutableArray alloc] init];
[arguments addObjectsFromArray:@[
Expand Down Expand Up @@ -47,15 +47,15 @@ @implementation FBXcodeBuildOperation

// Add environments for xcodebuild method swizzling if a simulator device set is provided
if (simDeviceSetPath) {
if (!configuration.shims || !configuration.shims.macOSTestShimPath) {
if (!macOSTestShimPath) {
return [[XCTestBootstrapError describe:@"Failed to locate the shim file for xcodebuild method swizzling"] failFuture];
}
environment[XcodebuildEnvironmentDeviceSetPath] = simDeviceSetPath;
if (environment[XcodebuildEnvironmentInsertDylib]) {
environment[XcodebuildEnvironmentInsertDylib] = [NSString stringWithFormat:@"%@%@%@", environment[XcodebuildEnvironmentInsertDylib], @":", configuration.shims.macOSTestShimPath];
environment[XcodebuildEnvironmentInsertDylib] = [NSString stringWithFormat:@"%@%@%@", environment[XcodebuildEnvironmentInsertDylib], @":", macOSTestShimPath];
}
else {
environment[XcodebuildEnvironmentInsertDylib] = configuration.shims.macOSTestShimPath;
environment[XcodebuildEnvironmentInsertDylib] = macOSTestShimPath;
}
}

Expand Down
3 changes: 1 addition & 2 deletions XCTestBootstrapTests/Tests/FBXcodeBuildOperationTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,7 @@ - (void)testUITestConfiguration
resultBundlePath:nil
reportActivities:NO
coveragePath:nil
logDirectoryPath:nil
shims:nil];
logDirectoryPath:nil];

NSDictionary *properties = [FBXcodeBuildOperation xctestRunProperties:configuration];
NSDictionary *stubBundleProperties = properties[@"StubBundleId"];
Expand Down
3 changes: 1 addition & 2 deletions fbxctest/FBXCTestKit/Runners/FBTestRunStrategy.m
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,7 @@ - (instancetype)initWithTarget:(id<FBiOSTarget, FBXCTestExtendedCommands>)target
resultBundlePath:nil
reportActivities:NO
coveragePath:nil
logDirectoryPath:nil
shims:nil];
logDirectoryPath:nil];

__block id<FBiOSTargetOperation> tailLogOperation = nil;
FBFuture<NSNull *> *executionFinished = [FBManagedTestRunStrategy
Expand Down
6 changes: 2 additions & 4 deletions idb_companion/Utility/FBXCTestDescriptor.m
Original file line number Diff line number Diff line change
Expand Up @@ -530,8 +530,7 @@ - (NSSet *)architectures
resultBundlePath:nil
reportActivities:request.reportActivities
coveragePath:coveragePath
logDirectoryPath:logsDirectory
shims:nil];
logDirectoryPath:logsDirectory];
}];
}

Expand Down Expand Up @@ -624,8 +623,7 @@ - (NSSet *)architectures
resultBundlePath:resultBundlePath
reportActivities:request.reportActivities
coveragePath:nil
logDirectoryPath:nil
shims:shims];
logDirectoryPath:nil];
}];
}

Expand Down

0 comments on commit ec1d271

Please sign in to comment.