Do not sign macos bundles

Summary: It's not required to sign macOS test bundles because they don't run on a simulator, an operation that takes a lot of time.

Reviewed By: lawrencelomax, sandeepkumarpani888, jbardini

Differential Revision: D29481622

fbshipit-source-id: 20b1cb4f6d013c786c1532148a53319b83193cfd

FBControlCore/Codesigning/FBCodesignProvider.m

@@ -67,6 +67,7 @@ + (NSRegularExpression *)cdHashRegex
   }
   id<FBControlCoreLogger> logger = self.logger;
   [logger logFormat:@"Signing bundle %@ with identity %@", bundlePath, self.identityName];
+
   return [[[[[[[FBTaskBuilder
     withLaunchPath:@"/usr/bin/codesign" arguments:@[@"-s", self.identityName, @"-f", bundlePath]]
     withNoUnacceptableStatusCodes]

FBControlCore/Management/FBiOSTarget.h

@@ -190,6 +190,13 @@ extern FBiOSTargetStateString const FBiOSTargetStateStringUnknown;
  */
 - (NSComparisonResult)compare:(id<FBiOSTarget>)target;
 
+/**
+ If the target's bundle needs to be codesigned or not.
+
+ @return if it needs to be signed or not.
+ */
+- (BOOL)requiresBundlesToBeSigned;
+
 /**
   Env var replacements
  

FBControlCoreTests/Doubles/FBiOSTargetDouble.m

@@ -177,4 +177,9 @@ - (NSComparisonResult)compare:(id<FBiOSTarget>)target
   return [FBFuture futureWithError:[[FBControlCoreError describe:@"Unimplemented"] build]];
 }
 
+- (BOOL) requiresBundlesToBeSigned
+{
+  return NO;
+}
+
 @end

FBDeviceControl/Management/FBDevice.m

@@ -132,6 +132,10 @@ - (NSComparisonResult)compare:(id<FBiOSTarget>)target
   return NSDictionary.dictionary;
 }
 
+- (BOOL) requiresBundlesToBeSigned {
+  return YES;
+}
+
 #pragma mark NSObject
 
 - (NSString *)description

FBSimulatorControl/Management/FBSimulator.m

@@ -175,6 +175,10 @@ - (NSComparisonResult)compare:(id<FBiOSTarget>)target
   };
 }
 
+- (BOOL) requiresBundlesToBeSigned {
+  return YES;
+}
+
 #pragma mark Properties
 
 - (FBControlCoreProductFamily)productFamily

XCTestBootstrap/MacStrategies/FBMacDevice.m

@@ -239,6 +239,9 @@ - (nonnull NSString *)consoleString
 @synthesize containerApplication;
 @synthesize deviceType;
 
+- (BOOL) requiresBundlesToBeSigned {
+  return NO;
+}
 
 + (nonnull instancetype)commandsWithTarget:(nonnull id<FBiOSTarget>)target
 {

idb_companion/Utility/FBIDBStorageManager.m

@@ -153,7 +153,7 @@ - (BOOL)checkArchitecture:(FBBundleDescriptor *)bundle error:(NSError **)error
   [self.logger logFormat:@"Persisted %@", bundle.identifier];
 
   FBInstalledArtifact *artifact = [[FBInstalledArtifact alloc] initWithName:bundle.identifier uuid:bundle.binary.uuid];
-  if (!self.relocateLibraries) {
+  if (!self.relocateLibraries || ![self.target requiresBundlesToBeSigned]) {
     return [FBFuture futureWithResult:artifact];
   }
   bundle = [FBBundleDescriptor bundleFromPath:destinationBundlePath.path error:&error];