Multiple calls of 'include' do not check for file modification HHVM 3.5.0

[uwetews]

No description provided.

[fredemmott]

This is not currently supported. While we do intend to fix this eventually when running from source files, keep in mind it will not be fully compatible, as we will not support this (or any kind of eval()/generated code) in Repo Authoritative mode.

One approach to work around this for non-repo-authoritative mode is to put a timestamp (if it's updated rarely) or hash of the source in the filename.

[fredemmott]

There is an incomplete patch at #2357

This is also related to #1447

[uwetews]

Smarty does compile template source into PHP files and/or creates output PHP cache files.
When a page is called normally the compiled or cache template PHP files are included for processing.
These files contain code and data about template and subtemplate source dependicies and other information to determine if the compiled template or cache file is still valid or needs to be updated.
In the later case Smarty does overwrite the include file with same name but new content. The new include file is loaded again for processing and displaying the page.

Because of the problem the include file was updated on disk, but the old content will be displayed on the current request. The new content will be displayed correct on the next request for that page.

PHP does recheck the filestats on each include/require, will detect the file modification and include the updated file when called multiple times in the same script.

Using timestamp or hash of source does not work in our case because compiled and cache files may contain content of many individual template source files. So the file name can't be computed when a page is called.

I think this could be a major problem for all applications which will create/update PHP or Hack files.

Currently many of our units test do fail under HHVM as we do test recompilation and cache updates very intense. Currently we do have about 1900 individual tests to run. I tried to isolate the critical tests and run them in separate processes. But it seems that there could be race conditions between the individual processes as I get random errors.

[r3wt]

i just disable the templating and use nginx fastcgi cache as a work around.

[mikehaertl]

+1 For fixing this. Another affected package is the yii2-composer package, which is a requirement for installing Yii2 via composer. This is a composer plugin that updates a list of installed extensions in vendor/yiisoft/extensions.php and therefore reads and writes that file a couple of times during the runtime of composer.

[belgattitude]

+1 for fixing include behaviour (a way to include multiple time a same file). I ran into an issue with some unit tests independently than smarty.

[uwetews]

For Smarty I have implemented a workaround for this problem.
The patch is the Smarty dev-master branch and will later be included in Smarty 3.1.28.

[mofarrell]

This was fixed.