Revert "Disable DateTimeFormat::formatToParts for Apple platform (#1155)" #1567
Conversation
facebook-github-bot
added
the
CLA Signed
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cipolleschi
force-pushed
the
cipolleschi/revert-intl
branch
from
ceaea5d to
86bc065
Compare
|
@cipolleschi has updated the pull request. You must reimport the pull request before landing. |
cipolleschi
force-pushed
the
cipolleschi/revert-intl
branch
from
86bc065 to
439aadb
Compare
|
@cipolleschi has updated the pull request. You must reimport the pull request before landing. |
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cipolleschi
force-pushed
the
cipolleschi/revert-intl
branch
from
439aadb to
cb6ecca
Compare
|
@cipolleschi has updated the pull request. You must reimport the pull request before landing. |
cipolleschi
force-pushed
the
cipolleschi/revert-intl
branch
from
cb6ecca to
355f514
Compare
|
@cipolleschi has updated the pull request. You must reimport the pull request before landing. |
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cipolleschi
force-pushed
the
cipolleschi/revert-intl
branch
from
355f514 to
d2efad0
Compare
|
@cipolleschi has updated the pull request. You must reimport the pull request before landing. |
cipolleschi
force-pushed
the
cipolleschi/revert-intl
branch
from
d2efad0 to
a93edbc
Compare
|
@cipolleschi has updated the pull request. You must reimport the pull request before landing. |
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
…)" This reverts commit c5a633f.
cipolleschi
force-pushed
the
cipolleschi/revert-intl
branch
from
a93edbc to
4fb9498
Compare
|
@cipolleschi has updated the pull request. You must reimport the pull request before landing. |
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cipolleschi merged this pull request in ac557bb. |
…)" (#1567) (#1567) Summary: Original Author: [email protected] Original Git: ac557bb Original Reviewed By: blakef Original Revision: D66099176 This reverts commit c5a633f. That commit removed the Intl.DateTimeFormat.formatToParts for Apple platforms from Hermes. However, the community started depending on it, and we ended up manually reverting that commit in the release branch for the past 3 releases. This is like reverting the commit in main, so we are proceeding with that approach to simplify the release process of React Native and Hermes to the OSS. Pull Request resolved: #1567 Pulled By: cipolleschi Reviewed By: neildhar Differential Revision: D68868242 fbshipit-source-id: c06b9821feb57507c7380358a7181747b91b0de5
Summary
This reverts commit c5a633f.
That commit removed the Intl.DateTimeFormat.formatToParts for Apple platforms from Hermes.
However, the community started depending on it, and we ended up manually reverting that commit in the release branch for the past 3 releases.
This is like reverting the commit in main, so we are proceeding with that approach to simplify the release process of React Native and Hermes to the OSS.
Test Plan
CI