Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Disable DateTimeFormat::formatToParts for Apple platform (#1155)" #1567

Closed
wants to merge 1 commit into from

Conversation

cipolleschi
Copy link

Summary

This reverts commit c5a633f.

That commit removed the Intl.DateTimeFormat.formatToParts for Apple platforms from Hermes.
However, the community started depending on it, and we ended up manually reverting that commit in the release branch for the past 3 releases.

This is like reverting the commit in main, so we are proceeding with that approach to simplify the release process of React Native and Hermes to the OSS.

Test Plan

CI

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Nov 18, 2024
@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cipolleschi cipolleschi force-pushed the cipolleschi/revert-intl branch from ceaea5d to 86bc065 Compare November 21, 2024 11:27
@facebook-github-bot
Copy link
Contributor

@cipolleschi has updated the pull request. You must reimport the pull request before landing.

@cipolleschi cipolleschi force-pushed the cipolleschi/revert-intl branch from 86bc065 to 439aadb Compare November 21, 2024 11:46
@facebook-github-bot
Copy link
Contributor

@cipolleschi has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cipolleschi cipolleschi force-pushed the cipolleschi/revert-intl branch from 439aadb to cb6ecca Compare November 21, 2024 17:12
@facebook-github-bot
Copy link
Contributor

@cipolleschi has updated the pull request. You must reimport the pull request before landing.

@cipolleschi cipolleschi force-pushed the cipolleschi/revert-intl branch from cb6ecca to 355f514 Compare November 21, 2024 17:14
@facebook-github-bot
Copy link
Contributor

@cipolleschi has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cipolleschi cipolleschi force-pushed the cipolleschi/revert-intl branch from 355f514 to d2efad0 Compare November 22, 2024 10:31
@facebook-github-bot
Copy link
Contributor

@cipolleschi has updated the pull request. You must reimport the pull request before landing.

@cipolleschi cipolleschi force-pushed the cipolleschi/revert-intl branch from d2efad0 to a93edbc Compare November 22, 2024 10:50
@facebook-github-bot
Copy link
Contributor

@cipolleschi has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Unverified

No user is associated with the committer email.
…)"

This reverts commit c5a633f.
@cipolleschi cipolleschi force-pushed the cipolleschi/revert-intl branch from a93edbc to 4fb9498 Compare November 22, 2024 13:14
@facebook-github-bot
Copy link
Contributor

@cipolleschi has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@cipolleschi merged this pull request in ac557bb.

facebook-github-bot pushed a commit that referenced this pull request Jan 30, 2025
…)" (#1567) (#1567)

Summary:
Original Author: [email protected]
Original Git: ac557bb
Original Reviewed By: blakef
Original Revision: D66099176

This reverts commit c5a633f.

That commit removed the Intl.DateTimeFormat.formatToParts for Apple platforms from Hermes.
However, the community started depending on it, and we ended up manually reverting that commit in the release branch for the past 3 releases.

This is like reverting the commit in main, so we are proceeding with that approach to simplify the release process of React Native and Hermes to the OSS.

Pull Request resolved: #1567

Pulled By: cipolleschi

Reviewed By: neildhar

Differential Revision: D68868242

fbshipit-source-id: c06b9821feb57507c7380358a7181747b91b0de5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants