Avoid creating global properties in StackTracesTreeTest.WithSourceMap (…

…#774) Summary: Pull Request resolved: #774 Creating global properties here means the test can break under certain build configurations, since it can result in allocations that then create additional entries. Reviewed By: jpporto Differential Revision: D37744060 fbshipit-source-id: 5d8dddef0e990fa54aad3464661bc2849a0d1c9f
facebook · Jul 10, 2022 · aa83f8b · aa83f8b
1 parent 1dbf8fd
commit aa83f8b
Showing 1 changed file with 53 additions and 43 deletions.
diff --git a/unittests/VMRuntime/StackTracesTreeTest.cpp b/unittests/VMRuntime/StackTracesTreeTest.cpp
@@ -787,13 +787,15 @@ TEST_F(StackTracesTreeTest, WithSourceMap) {
 
   ASSERT_TRUE(runWithSourceMap(
       R"#(
-function bar() {
-  return new Object();
-};
-function foo() {
-  return bar();
-};
-foo();
+(function (){
+  function bar() {
+    return new Object();
+  };
+  function foo() {
+    return bar();
+  };
+  return foo();
+})();
       )#",
       sourceMapGen));
 
@@ -817,36 +819,65 @@ foo();
         {
           "name": "global",
           "scriptName": "JavaScript",
-          "line": 8,
-          "col": 4,
+          "line": 10,
+          "col": 3,
           "children": [
             {
-              "name": "foo",
+              "name": "(anonymous)",
               "scriptName": "JavaScript",
-              "line": 6,
+              "line": 9,
               "col": 13,
               "children": [
                 {
-                  "name": "bar",
+                  "name": "foo",
                   "scriptName": "JavaScript",
-                  "line": 3,
-                  "col": 20,
-                  "children": []
+                  "line": 7,
+                  "col": 15,
+                  "children": [
+                    {
+                      "name": "bar",
+                      "scriptName": "JavaScript",
+                      "line": 4,
+                      "col": 22,
+                      "children": []
+                    },
+                    {
+                      "name": "bar",
+                      "scriptName": "JavaScript",
+                      "line": 3,
+                      "col": 3,
+                      "children": []
+                    }
+                  ]
                 },
                 {
-                  "name": "bar",
+                  "name": "foo",
                   "scriptName": "JavaScript",
-                  "line": 2,
-                  "col": 1,
+                  "line": 6,
+                  "col": 3,
                   "children": []
                 }
               ]
             },
             {
-              "name": "foo",
+              "name": "(anonymous)",
               "scriptName": "JavaScript",
-              "line": 5,
-              "col": 1,
+              "line": 2,
+              "col": 2,
+              "children": []
+            },
+            {
+              "name": "(anonymous)",
+              "scriptName": "JavaScript",
+              "line": 2,
+              "col": 2,
+              "children": []
+            },
+            {
+              "name": "(anonymous)",
+              "scriptName": "JavaScript",
+              "line": 2,
+              "col": 2,
               "children": []
             }
           ]
@@ -855,28 +886,7 @@ foo();
           "name": "global",
           "scriptName": "JavaScript",
           "line": 2,
-          "col": 1,
-          "children": []
-        },
-        {
-          "name": "global",
-          "scriptName": "JavaScript",
-          "line": 2,
-          "col": 1,
-          "children": []
-        },
-        {
-          "name": "global",
-          "scriptName": "JavaScript",
-          "line": 2,
-          "col": 1,
-          "children": []
-        },
-        {
-          "name": "global",
-          "scriptName": "JavaScript",
-          "line": 2,
-          "col": 1,
+          "col": 2,
           "children": []
         }
       ]