Skip to content

Commit

Permalink
Use the same AndroidUnicodeUtils.java everywhere
Browse files Browse the repository at this point in the history
Summary:
hermes and hermes-snapshot have this issue where including both and use
their own copies of AndroidUnicodeUtils would cause a package name
clash. This is because by having different dependencies, BUCK will try
to include 2 packages that have the same package name. The solution
used before was to have both take dependency on the same copy of
AndroidUnicodeUtils.

Now that we're trying to include both Hermes and Static Hermes, we have
the same exact issue. For now I'm taking the same approach by moving to
a common copy. The code is identical so there isn't a behavioral change.

Reviewed By: neildhar

Differential Revision: D68173770

fbshipit-source-id: ae62a35a49fc7b8b9680cb47f40457137f717c4d
  • Loading branch information
dannysu authored and facebook-github-bot committed Jan 30, 2025
1 parent 7d1fbde commit 3b3584d
Showing 1 changed file with 0 additions and 82 deletions.

This file was deleted.

0 comments on commit 3b3584d

Please sign in to comment.