Fix exact object indexer issue 7128 and 7240 #7271
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
villesau
force-pushed
the
fix-exact-string-indexer-issue
branch
from
ef3ea55 to
950ad49
Compare
villesau
force-pushed
the
fix-exact-string-indexer-issue
branch
from
950ad49 to
4e0c018
Compare
villesau
changed the title
There was a problem hiding this comment.
@jbrown215 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
villesau
changed the title
villesau
changed the title
|
Is there any reason this didn't get merged? Would be nice 😄 |
|
@jedwards1211 I had totally forgotten this PR :D I think here is the most comprehensive discussion about the topic: #7128 Most likely too much has changed since the PR that this could be taken in. Maybe @jbrown215 could comment on this? |
|
Closing this PR since all mentioned issues have been fixed. Most recently, #7128 is addressed with newly introduced mapped type. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #7128 and #7240
Root cause for both issues were same.
In overall I think that singleton string indexer properties should be treated as a regular keys from the get go but that's probably bigger change. The change introduced in this PR is probably fine for now as nothing broke, and test harness around exact indexer properties is now slightly better.
Having debugger setup in place helps a lot: #4181 (comment)