Fix for class method default parameters that use this
#3334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonbretman
force-pushed
the
class-method-default-parameters
branch
2 times, most recently
from
0a49076 to
b9e64d7
Compare
|
Think I'm going to need some help understanding the build failure in Travis for OCaml 4.03.0 😕 |
|
The build error looks like some kind of caching problem (we seem to cache build artifacts in Travis). |
|
@jeffmo failed again 😿 |
|
Shooting in the dark a bit now, but what happens if you rebase? In any case, I don't see how this would be related to your change -- but it would be nice to rule out the CI issue if possible. |
jonbretman
force-pushed
the
class-method-default-parameters
branch
from
b9e64d7 to
581c85c
Compare
|
@jeffmo let's find out! Rebased + pushed. |
|
@jeffmo has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example of bug - https://flowtype.org/try/#0PQKgBAAgZgNg9gdzCYAoVBjGBDAzrsAQTAG9UwxyxsAuMXAFwCcBLAOwHMqqAjACgxgAvGAYALFrgB02AJSkqFKgF9uyoA