Skip to content

Commit

Permalink
[hack] Include debug symbols in OSS build
Browse files Browse the repository at this point in the history
Summary: Maybe this is why OCAMLRUNPARAM=b doesn't seem to do anything
when we get external bug reports?

Reviewed By: @int3

Differential Revision: D2170316
  • Loading branch information
jwatzman authored and facebook-github-bot-9 committed Jun 19, 2015
1 parent 34a0ce2 commit 419d159
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions hack/Makefile
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
# Copyright (c) 2014, Facebook, Inc.
# All rights reserved.

################################################################################
# Variables to override #
################################################################################
Expand Down Expand Up @@ -121,16 +118,16 @@ $(TARGETS): $(ALL_SRC_FILES)
# build-hack-native-deps is a dependency of $(TARGETS) but as it is phony
# we place it here to avoid unnecessary rebuilds
$(MAKE) build-hack-native-deps build-hhi-archive
ocamlbuild -no-links $(INCLUDE_OPTS) $(LIB_OPTS) \
-lflags "$(LINKER_FLAGS)" \
ocamlbuild -no-links -cflag -g $(INCLUDE_OPTS) $(LIB_OPTS) \
-lflags "-g $(LINKER_FLAGS)" \
$(patsubst _build/%,%,$(TARGETS))
# Touching the targets is necessary because the ocaml build
# doesn't change the modification dates of the targets if
# the new binaries are exactly the same as the old ones
touch $(TARGETS)

build-hack-native-deps: build-hack-stubs
ocamlbuild -cflags "$(EXTRA_INCLUDE_OPTS) $(EXTRA_CC_OPTS)" $(NATIVE_OBJECT_FILES)
ocamlbuild -cflags "-g $(EXTRA_INCLUDE_OPTS) $(EXTRA_CC_OPTS)" $(NATIVE_OBJECT_FILES)

build-hack-stubs:
REV="const char* const BuildInfo_kRevision = \"$$(git rev-parse HEAD)\";"; \
Expand Down

0 comments on commit 419d159

Please sign in to comment.