Skip to content

Commit

Permalink
Enable reflect codec for SkynetStructs_CrossDbApps
Browse files Browse the repository at this point in the history
Reviewed By: podtserkovskiy

Differential Revision: D65074082

fbshipit-source-id: 417febfb7805a00960440a4f75ad72a127c26496
  • Loading branch information
echistyakov authored and facebook-github-bot committed Oct 29, 2024
1 parent 4f716ae commit bc71935
Show file tree
Hide file tree
Showing 83 changed files with 28,959 additions and 5 deletions.
2 changes: 1 addition & 1 deletion thrift/compiler/generate/go/util.cc
Original file line number Diff line number Diff line change
Expand Up @@ -531,7 +531,7 @@ bool is_type_go_comparable(
// Whether the underlying Go type is comparable.
// As per: https://go.dev/ref/spec#Comparison_operators
// > Slice, map, and function types are not comparable.
// (By extension - structs with slice of map fields are incomparable.)
// (By extension - structs with slice or map fields are incomparable.)

// Struct hierarchy can sometime be recursive.
// Check if we have already visited this type.
Expand Down
4 changes: 1 addition & 3 deletions thrift/compiler/generate/t_mstch_go_generator.cc
Original file line number Diff line number Diff line change
Expand Up @@ -887,12 +887,10 @@ void t_mstch_go_generator::generate_program() {
render_to_file(prog, "const.go", package_dir / "const.go");
render_to_file(prog, "types.go", package_dir / "types.go");
render_to_file(prog, "svcs.go", package_dir / "svcs.go");
render_to_file(prog, "codec.go", package_dir / "codec.go");
if (data_.gen_metadata) {
render_to_file(prog, "metadata.go", package_dir / "metadata.go");
}
if (data_.use_reflect_codec) {
render_to_file(prog, "codec.go", package_dir / "codec.go");
}
if (program->has_doc()) {
render_to_file(prog, "doc.go", package_dir / "doc.go");
}
Expand Down
Loading

0 comments on commit bc71935

Please sign in to comment.