Fix the bogus high write delay latency metric

Reviewed By: kaczmarekmhl Differential Revision: D62313198 fbshipit-source-id: 626999588a6f47ea6ceb9337199340bd4fae558a
facebook · Sep 6, 2024 · 0dc60d6 · 0dc60d6
1 parent 826532d
commit 0dc60d6
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/thrift/lib/cpp/server/TServerObserver.h b/thrift/lib/cpp/server/TServerObserver.h
@@ -118,14 +118,16 @@ class TServerObserver {
     }
 
     folly::Optional<uint64_t> writeDelayLatencyUsec() const {
-      if (writeBegin != clock::time_point()) {
+      if (writeBegin != clock::time_point() &&
+          processEnd != clock::time_point()) {
         return to_microseconds(writeBegin - processEnd);
       }
       return {};
     }
 
     folly::Optional<uint64_t> writeLatencyUsec() const {
-      if (writeBegin != clock::time_point()) {
+      if (writeBegin != clock::time_point() &&
+          writeEnd != clock::time_point()) {
         return to_microseconds(writeEnd - writeBegin);
       }
       return {};