Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Migration Website to Docusaurus 2 Alpha #89

Closed
dtaylorbrown opened this issue Oct 12, 2019 · 14 comments
Closed

Migration Website to Docusaurus 2 Alpha #89

dtaylorbrown opened this issue Oct 12, 2019 · 14 comments

Comments

@dtaylorbrown
Copy link

Hi there! The Docusaurus team is currently developing Docusaurus 2 and are almost done with an MVP that doesn't include translations and versioning features, which means there's feature parity with your website's current usage of Docusaurus.

Docusaurus 2 brings about many improvements:

  • Client-side rendering with prerendering (site renders without JavaScript!)
  • More flexible appearance - Customizable layouts, CSS modules, etc
  • Embeddable interactive React components within markdown via MDX

I will be your POC in helping you throughout the migration process. Let me know what you think!

cc @yangshun @endiliey

@yangshun
Copy link
Contributor

Ref: facebook/docusaurus#1834

@jrwats
Copy link
Contributor

jrwats commented Oct 18, 2019

Embeddable interactive React components within markdown via MDX

Yes! I've been wanting to add our demo app to the docs! https://i.giphy.com/3o6ZteX8cqJRH4TwQ0.gif

cc @w1106c @kayhadrin

@yangshun
Copy link
Contributor

Btw @sshhdaniella is saying that he will be helping to do the migration. On our end we just need to review.

@jrwats
Copy link
Contributor

jrwats commented Oct 18, 2019

Sorry are we

  1. Supposed to do this migration and have you/Daniella review, or
  2. is @sshhdaniella doing this migration with your review?

Either way it'll be nice to have embedded React

@yangshun
Copy link
Contributor

Option 2. @sshhdaniella will do the migration, we (Docusaurus side + FBT) will review together

@jrwats
Copy link
Contributor

jrwats commented Oct 18, 2019

Awesome

@jrwats
Copy link
Contributor

jrwats commented Oct 31, 2019

@sshhdaniella, what does your timeline look like for this? I ask because we have 2 vulnerabilities from the packages remarkable <= 1.7.1 and underscore.string < 3.3.5 that are only brought in due to Docusaurus v1.

@yangshun
Copy link
Contributor

yangshun commented Nov 1, 2019

Hey @jrwats, for those Docusaurus 1 security vulnerabilities, I've fixed them upstream and upgrading your Docusaurus version would get rid of them. You could do that first in the meanwhile.

@jrwats
Copy link
Contributor

jrwats commented Nov 1, 2019

It looks like docusaurus v1.14.0 still depends on [email protected].

Does this actually fix the security vulnerability? The issue I have says there's "No fix version known"

Package name: remarkable
Affected versions: <= 1.7.1
Fixed in version: (No fix version known)
CVE: CVE-2019-12043
Reference: https://nvd.nist.gov/vuln/detail/CVE-2019-12043

@jrwats
Copy link
Contributor

jrwats commented Nov 20, 2019

@yangshun remarkable 1.7.4 is still bringing in underscore.string too

@yangshun
Copy link
Contributor

@sshhdaniella I'm freeing up this issue for others to take up since we have not gotten a response from you. Let us know if you're still interested.

@yangshun
Copy link
Contributor

@jrwats apologies for the mistake, it's weird that only fbt is seeing the vulnerability. I'll try to get someone to migrate fbt or even do it myself so that the vulnerability goes away.

For the most part, most security vulnerabilities are low-signal and since docusaurus produces statically generated sites, the severity is smaller.

@endiliey
Copy link
Contributor

try running yarn upgrade to recreate lockfile. also make sure to update to latest version of docusaurus

@dtaylorbrown
Copy link
Author

@yangshun Hi, apologies for the delay. I've recently gotten married and have since been away and taken some time off. Yes, please feel free to re-assign, I most likely won't get the time in the coming weeks to work on this.

facebook-github-bot pushed a commit that referenced this issue Dec 1, 2019
Summary:
- Live version: https://fbt.ozgunbal.now.sh/
- There are blog posts but I kept same as current site. There's no blog link at the top right now.
- Hey, yangshun and endiliey . You can check it when you're available.
- This PR related to #89 and facebook/docusaurus#1834
Pull Request resolved: #113

Differential Revision: D18758345

Pulled By: jrwats

fbshipit-source-id: 8023c961c94521d5e973d6f340d5b67372260860
@jrwats jrwats closed this as completed Dec 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants