feat: update eslint deps #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bradzacher
commented
Jul 8, 2022
bradzacher
commented
- update to ESLint v8
- switch babel-eslint for hermes-eslint
- update eslint plugin versions
- update to ESLint v8 - switch babel-eslint for hermes-eslint - update eslint plugin versions
zpao
requested changes
Jul 11, 2022
| @@ -16,23 +16,23 @@ There are several exceptions: | |||
| npm install --save-dev \ | |||
| eslint-config-fbjs \ | |||
| eslint-plugin-babel \ | |||
| eslint-plugin-flowtype \ | |||
| eslint-plugin-ft-flow \ | |||
| eslint-plugin-jsx-a11y \ | |||
| eslint-plugin-react \ | |||
There was a problem hiding this comment.
theoretically, we probably want to add https://www.npmjs.com/package/eslint-plugin-react-hooks to this config (and make sure the right rules are enabled) but that's distinct from the effort you have now. Fits with my version bump outside PRs though :)
There was a problem hiding this comment.
ideally i'd want us to do even less in this config and push for our codebases to rely on the purely internal configs!
This was referenced Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.