Skip to content

Commit

Permalink
Remove the publish_cocoapods step from CircleCI since its not possibl…
Browse files Browse the repository at this point in the history
…e for it to work on a draft release

Summary: The release has to be published so that the XCFramework assets uploaded to the release are public for CocoaPods to find

Reviewed By: samodom

Differential Revision: D34114881

fbshipit-source-id: 6cc7412df3d50b7523aa554b178eb10874eb050b
  • Loading branch information
jawwad authored and facebook-github-bot committed Feb 9, 2022
1 parent c271024 commit 6229631
Showing 1 changed file with 0 additions and 14 deletions.
14 changes: 0 additions & 14 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,6 @@ commands:
command: echo 'chruby ruby-2.7' >> ~/.bash_profile
- run: gem install cocoapods

publish_cocoapods:
description: Pushes all CocoaPods to trunk

This comment has been minimized.

Copy link
@Kamalaqmal

Kamalaqmal Mar 7, 2023

ol;uoi

steps:
- attach_workspace:
at: .
- run: sh scripts/publish_cocoapods.sh

This comment has been minimized.

Copy link
@eramimohamed

eramimohamed Jul 9, 2023

im best

publish_to_github:
description: Creates a draft for a release on github
steps:
Expand All @@ -69,10 +62,6 @@ jobs:
<<: *useMacOS
steps:
- setup
publish-cocoapods:
<<: *useMacOS
steps:
- publish_cocoapods
publish-to-github:
docker:
- image: cibuilds/github:0.13
Expand All @@ -86,6 +75,3 @@ workflows:
<<: *onlyRunOnTags
- publish-to-github:
<<: *onlyRunOnTags
- publish-cocoapods:
<<: *onlyRunOnTags
<<: *requiresSetup

4 comments on commit 6229631

@2jessy2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice...

@sunny500
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello , please how can i update to the latest facebook SDK for IOS?

@Hebamabrouk
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

83577589_556345944958992_2558068442594803712_n

@eramimohamed
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

walcom__

Please sign in to comment.