Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 8.4 to GitHub workflows #2833

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Conversation

brezocordero
Copy link
Contributor

@brezocordero brezocordero commented Nov 23, 2024

Changes proposed in this Pull Request:

Add PHP8.4 to GitHub Workflows for PHP Code Styling and Unit Tests.

It requires #2832 to be merged first so that the unit test pass.

I have updated composer.lock with composer update phpunit/phpunit --with-dependencies

Changelog entry

Tweak - PHP8.4 to GitHub PHPCS and Unit Tests workflows.

@github-actions github-actions bot added the changelog: tweak Small change, that isn't actually very important. label Nov 23, 2024
@brezocordero brezocordero marked this pull request as draft November 23, 2024 00:29
@brezocordero brezocordero marked this pull request as ready for review November 23, 2024 01:12
@brezocordero brezocordero requested a review from a team November 23, 2024 01:12
@facebook-github-bot
Copy link

Hi @brezocordero!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: tweak Small change, that isn't actually very important.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants