Adding event filtering. Only AddToCart events should be deferred. #2734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ase `cart redirect after add` option is active.
github-actions
bot
added
the
changelog: fix
ibndawood
approved these changes
May 3, 2024
There was a problem hiding this comment.
Thank you, @message-dimke, for addressing this issue. The code looks good to me!
|
Great! Thanks @message-dimke @ibndawood . Looking forward to the release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Closes #2731 .
Not all events must be deferred if the
redirect to cart after addsetting is ON. Defer only AddToCart events.Changelog entry