You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.
Motivation
I'm trying to make #9379 more visible. This PR adds the blog URL of the Docusaurus website to the evalutated URLs.
Test Plan
If this surfaces console errors in lighthouse then it demostrates it's an underlying issue with the Docusaurus blog section - though weirdly one that only seems to surface on Ubuntu
@slorber I'm not seeing the addition of the /blogs endpoint show up here for some reason - does the PR need to be merged for us to be able to see /blog resultsor something (because I'm coming from a fork)?
@slorber I'm not seeing the addition of the /blogs endpoint show up here for some reason - does the PR need to be merged for us to be able to see /blog resultsor something (because I'm coming from a fork)?
I think yes because we choose to use "pull_request_target" instead of "pull_request". Don't remember why exactly but I think it was related to security reasons, otherwise it's unsafe to add a comment.
Added a trailing slash because we use that for deploy previews + a more diverse set of Docusaurus pages
CLA SignedSigned Facebook CLApr: internalThis PR does not touch production code, or is not meaningful enough to be in the changelog.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
johnnyreilly
requested review from
slorber,
lex111 and
Josh-Cena
as code owners
slorber
added
the
pr: internal
Pre-flight checklist
Motivation
I'm trying to make #9379 more visible. This PR adds the blog URL of the Docusaurus website to the evalutated URLs.
Test Plan
If this surfaces console errors in lighthouse then it demostrates it's an underlying issue with the Docusaurus blog section - though weirdly one that only seems to surface on Ubuntu
Test links
Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs
#9379